From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105722 invoked by alias); 5 Feb 2020 10:08:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105714 invoked by uid 89); 5 Feb 2020 10:08:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=decent, people's, peoples X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.149.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2020 10:08:40 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 61D0A226DB for ; Wed, 5 Feb 2020 04:08:39 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id zHbriAQZ7KnV5zHbriwevP; Wed, 05 Feb 2020 04:08:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q8Pv2w6xfJDwvGT/K3JL1pTAUyST+Nqr0XGzeWjmHq4=; b=TlA0dcg/+qosI0R31HO2Er4/Hw jAyk6wHvjNdTSQFKZCUtd3nnzrTPpG91BVD7bXVXhk02nS1d3IHmv21RuC/Mjqe+j+9wyrYoop446 qoABkw5jjGccokX1BwZPMTTxc; Received: from dsl093-174-036-212.dialup.saveho.com ([93.174.36.212]:23098 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1izHbq-002tOy-Iu; Wed, 05 Feb 2020 03:08:39 -0700 From: Tom Tromey To: Joel Brobecker Cc: Jonah Graham , Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: Propose we release GDB 9.1 next weekend (Feb 01-02) References: <20200126114033.GA20733@adacore.com> <20200201121720.GA30012@adacore.com> <20200201130634.GA3103@adacore.com> Date: Wed, 05 Feb 2020 10:08:00 -0000 In-Reply-To: <20200201130634.GA3103@adacore.com> (Joel Brobecker's message of "Sat, 1 Feb 2020 17:06:34 +0400") Message-ID: <87blqdgxd2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00086.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> FWIW, in terms of reverting, I was only thinking of reverting Joel> in the gdb-9-branch. I sent a reversion patch. It's pretty straightforward, but take a quick look anyway. Joel> It's possible we might decide to revert Joel> in master as well, but, at the moment, it's looking like we have Joel> a decent chance of fixing the issue in master withing a reasonable Joel> time frame. So I'm not advocating for a revert in master just yet. Joel> Open to people's thoughts, though, as always! I wasn't sure what to do here, either. For trunk I think we should at least have a regression test for the bug exposed in PR breakpoints/24915. I suppose right now the name to search by and the name to display are entangled in the code. So maybe another approach to fixing the original problem would be to untangle them somehow. I recall wanting to move this information into the source cache, and out of the symtabs; but I looked at this and it was a little complicated because, IIRC, the search can depend on the path to the objfile. Maybe we could have a unified table per objfile though, the idea being to consolidate and cache the lookups, so that (1) it's shared across symtabs and psymtabs, and (2) things like the name to print can be computed lazily if possible. Hopefully this makes sense, Tom