From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QPLlD1eXyl+hPwAAWB0awg (envelope-from ) for ; Fri, 04 Dec 2020 15:08:55 -0500 Received: by simark.ca (Postfix, from userid 112) id 3A31E1F0AB; Fri, 4 Dec 2020 15:08:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB3651E552 for ; Fri, 4 Dec 2020 15:08:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0E473860C39; Fri, 4 Dec 2020 20:08:54 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 6FE11385EC55 for ; Fri, 4 Dec 2020 20:08:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FE11385EC55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 81D7A117427; Fri, 4 Dec 2020 15:08:51 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rKd6uJ+X7Q3D; Fri, 4 Dec 2020 15:08:51 -0500 (EST) Received: from murgatroyd (97-122-89-243.hlrn.qwest.net [97.122.89.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 22BF9117278; Fri, 4 Dec 2020 15:08:51 -0500 (EST) From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH] Remove redundant typedefs References: <20201203192419.2861728-1-tromey@adacore.com> <056c4f42-4e85-dcaf-59e1-8483e9b6f876@simark.ca> X-Attribution: Tom Date: Fri, 04 Dec 2020 13:08:50 -0700 In-Reply-To: <056c4f42-4e85-dcaf-59e1-8483e9b6f876@simark.ca> (Simon Marchi's message of "Thu, 3 Dec 2020 14:33:28 -0500") Message-ID: <87blf95o6l.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >> @@ -794,7 +794,7 @@ struct breakpoint >> gdbpy_breakpoint_object *py_bp_object = NULL; >> >> /* Same as py_bp_object, but for Scheme. */ >> - gdbscm_breakpoint_object *scm_bp_object = NULL; >> + breakpoint_smob *scm_bp_object = NULL; Simon> In this case, I think it would make sense to keep the Simon> "gdbscm_breakpoint_object" name, first for symmetry with Python, but Simon> also because it's more descriptive than "breakpoint_smob", when you are Simon> not in the guile code. Makes sense. Simon> Since the code in scm-breakpoint.c uses breakpoint_smob everywhere (and Simon> in the context of guile, it's clear what a _smob is), you could just add Simon> a Simon> using breakpoint_smob = gdbscm_breakpoint_object; Simon> in that file. I just backed out this one specific change instead. Tom