From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 01LQGEHvCWBTFAAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 16:16:49 -0500 Received: by simark.ca (Postfix, from userid 112) id 55CA81EF80; Thu, 21 Jan 2021 16:16:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A60A1E590 for ; Thu, 21 Jan 2021 16:16:48 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0997F384B110; Thu, 21 Jan 2021 21:16:48 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.194.16]) by sourceware.org (Postfix) with ESMTPS id 5E374386186E for ; Thu, 21 Jan 2021 21:16:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E374386186E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id BC4DF5A52 for ; Thu, 21 Jan 2021 15:16:42 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2hJqlSMCODT642hJqlQkzE; Thu, 21 Jan 2021 15:16:42 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UMxRYtKVe1hh1PDtkF0a5VJg35VgFUJvocIbHq1QTZ8=; b=Rk3dE5c3sBp/lDznGYM1xYMYIT XgwepQAtL9cSlNqUT+KS+KYo6XUHGNjRMJqlrEG4D7KvqEDWeSR9A2/9D6mkI/4+1um0/imYR2uFj PbsxI0wHehlXfKoiSG0PNaAgW; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:35744 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2hJq-003p9q-Ft; Thu, 21 Jan 2021 14:16:42 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 01/30] Replace the symbol needs evaluator with a parser References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-2-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Thu, 21 Jan 2021 14:16:41 -0700 In-Reply-To: <20201207190031.13341-2-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:02 +0000") Message-ID: <87bldirnwm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2hJq-003p9q-Ft X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:35744 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> This patch addresses a design problem with the symbol_needs_eval_context Zoran> class. It exposes the problem by introducing two new testsuite test Zoran> cases. Zoran> + while (op_ptr < expr_end) Zoran> + { Zoran> + enum dwarf_location_atom op Zoran> + = (enum dwarf_location_atom) *op_ptr++; Zoran> + uint64_t uoffset; Zoran> + int64_t offset; IIUC this is the same as the earlier patch, that marches through the bytecode linearly. I think I sent comments on the earlier submission. Tom