From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hYi3OAezIWCTTAAAWB0awg (envelope-from ) for ; Mon, 08 Feb 2021 16:54:15 -0500 Received: by simark.ca (Postfix, from userid 112) id D6BAE1EF4F; Mon, 8 Feb 2021 16:54:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 15E961E4A3 for ; Mon, 8 Feb 2021 16:54:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3A9D389367C; Mon, 8 Feb 2021 21:54:14 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.194]) by sourceware.org (Postfix) with ESMTPS id 64BB5389367C for ; Mon, 8 Feb 2021 21:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64BB5389367C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D91323CA3 for ; Mon, 8 Feb 2021 15:54:11 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9ETzlcfyrDT649ETzlQyy5; Mon, 08 Feb 2021 15:54:11 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TpkRUrLQ5m3zrVLoiATiSk12dyK8Y1hlAjNnpoOphNY=; b=sIgUiTcgRzmEkwFw0L87Hx2VOP zYAyI1M6TCpw8KlPU92T2xNAXSLEnLGK9/RlzqrR3GYgLnujj9pO6NlHv6CH165lULaNwuqFlBw67 MIZIt+8lBhlrYlonoPQNv5r2D; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:38494 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9ETz-003VIi-Ke; Mon, 08 Feb 2021 14:54:11 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 18/30] Add new classes that model DWARF stack element References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-19-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Mon, 08 Feb 2021 14:54:11 -0700 In-Reply-To: <20201207190031.13341-19-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:19 +0000") Message-ID: <87blcudy4c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9ETz-003VIi-Ke X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:38494 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> +class dwarf_entry : public refcounted_object I guess reference counting is needed due to how dwarf_composite works. I suppose it's impossible to create a reference loop. But I wonder if ownership transfer is more correct and reference counting is not needed. Zoran> +class dwarf_implicit : public dwarf_location Zoran> +{ Zoran> +public: Zoran> + Zoran> + dwarf_implicit (const gdb_byte* contents, size_t size, Zoran> + enum bfd_endian byte_order) Zoran> + { Zoran> + m_contents.reset ((gdb_byte *) xzalloc (size)); This could just be a std::vector and m_size could be removed. Zoran> +class dwarf_composite : public dwarf_location Zoran> +{ Zoran> + Zoran> + /* A composite location gets detached from its factory object for Zoran> + the purpose of lval_computed resolution, which means that it Zoran> + needs to take care of garbage collecting its pieces. */ Zoran> + ~dwarf_composite () override Zoran> + { Zoran> + for (unsigned int i = 0; i < m_pieces.size (); i++) Zoran> + { Zoran> + dwarf_location* location = m_pieces[i].m_location; Zoran> + Zoran> + location->decref (); Zoran> + Zoran> + if (location->refcount () == 0) Zoran> + delete location; It's better to use the reference-counting smart pointer abstraction so that manual management is not needed. Zoran> + void add_piece (dwarf_location* location, ULONGEST bit_size) "dwarf_location *location" - this little typo appears in a few spots. Perhaps this should take a ref-pointer&& (I forget exactly how the type is spelled, you'll probably want a typedef anyway) to indicate transfer, or a "const .. &" and then use new_reference. Zoran> + class piece Zoran> + { Zoran> + public: Zoran> + piece (dwarf_location *location, ULONGEST size) Zoran> + : m_location (location), Zoran> + m_size (size) Zoran> + {} Zoran> + Zoran> + dwarf_location *m_location; This could have the smart pointer type. Tom