From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id V6xmKpfxImA4aQAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 15:33:27 -0500 Received: by simark.ca (Postfix, from userid 112) id 9FDDD1EF4F; Tue, 9 Feb 2021 15:33:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4E45C1E590 for ; Tue, 9 Feb 2021 15:33:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 037843840C1E; Tue, 9 Feb 2021 20:33:27 +0000 (GMT) Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.125]) by sourceware.org (Postfix) with ESMTPS id 00FAA3861843 for ; Tue, 9 Feb 2021 20:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 00FAA3861843 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 79EF0C483E1 for ; Tue, 9 Feb 2021 14:33:23 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9ZhLlrJPBHPnU9ZhLlNlIM; Tue, 09 Feb 2021 14:33:23 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lCSvZqfp40OnTSOj/4pgSi/s/nWr663BWYKy7rN5xK8=; b=U35qQZTFBIGqCSMvcaO+T6fZ8s 0IMgA15WwFEJzr1MDGazMGqJLFuci55Z+rWOE5Hbm2f/ykFaBurNar9qjGLKt0h2QnAuq3gc2lfQH jbIX+GdbAJMtyzUYdXV6VBewE; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:43094 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9ZhK-00233k-ME; Tue, 09 Feb 2021 13:33:22 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 15/30] Add as_lval argument to expression evaluator References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-16-Zoran.Zaric@amd.com> <87mtwedypn.fsf@tromey.com> X-Attribution: Tom Date: Tue, 09 Feb 2021 13:33:21 -0700 In-Reply-To: (Zoran Zaric via Gdb-patches's message of "Tue, 9 Feb 2021 15:25:02 +0000") Message-ID: <87blctasmm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9ZhK-00233k-ME X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:43094 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: >> While reading this, though, I was wondering if the new parameter ought >> to be given to the dwarf_expr_context constructor, rather than passed to >> the evaluation method. [...] Zoran> People didn't seem to like the idea of persistent evaluator so I guess Zoran> many more arguments (if not all) could be just moved to the Zoran> constructor. Zoran> In the later patches, the whole dwarf_expr_context class is hidden in Zoran> the expr.c file and we end up with just one dwarf2_eval_exp function Zoran> (which can be renamed to dwarf2_evaluate) that internally creates the Zoran> evaluator object and calls the evaluation. Zoran> In that sense, we can move most of the evaluation arguments to be a Zoran> constructor arguments and just leave the expression stream and result Zoran> types as evaluation method arguments. Zoran> If people really feel that there is no need for multiple calls to the Zoran> same evaluator object in the future, I will be happy to change it in Zoran> the next patch series. If it's all hidden, then I think it's fine either way, because the main interface is going to be something else anyway. So you might as well just leave it however you've got it now. Tom