From: Tom Tromey <tom@tromey.com>
To: Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Cc: Weimin Pan <weimin.pan@oracle.com>
Subject: Re: [PATCH,V2 2/5] CTF: set up debug info for function arguments
Date: Wed, 03 Mar 2021 13:41:42 -0700 [thread overview]
Message-ID: <87blc0ynp5.fsf@tromey.com> (raw)
In-Reply-To: <1614650018-9135-3-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Mon, 1 Mar 2021 20:53:35 -0500")
>>>>> ">" == Weimin Pan via Gdb-patches <gdb-patches@sourceware.org> writes:
>> Added this support in read_func_kind_type after gcc started generating
>> CTF for function arguments.
>> Expanded gdb.base/ctf-ptype.exp to test function arguments. Also fixed
>> some typos.
Thanks for the patch.
>> + if (cfi.ctc_flags & CTF_FUNC_VARARG)
The gdb style is to compare against zero, like:
if ((cfi.ctc_flags & CTF_FUNC_VARARG) != 0)
This is ok with this change.
Tom
next prev parent reply other threads:[~2021-03-03 20:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 1:53 [PATCH,V2 0/5] CTF: bug fixes and new features Weimin Pan via Gdb-patches
2021-03-02 1:53 ` [PATCH,V2 1/5] CTF: fix incorrect function return type Weimin Pan via Gdb-patches
2021-03-02 1:53 ` [PATCH,V2 2/5] CTF: set up debug info for function arguments Weimin Pan via Gdb-patches
2021-03-02 1:53 ` [PATCH,V2 3/5] CTF: handle forward reference type Weimin Pan via Gdb-patches
2021-03-02 1:53 ` [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab Weimin Pan via Gdb-patches
2021-03-02 1:53 ` [PATCH,V2 5/5] CTF: multi-CU and archive support Weimin Pan via Gdb-patches
2021-03-02 23:15 ` Lancelot SIX via Gdb-patches
2021-03-03 1:01 ` Wei-min Pan via Gdb-patches
2021-03-03 17:37 ` Lancelot SIX via Gdb-patches
2021-03-03 18:31 ` Weimin Pan via Gdb-patches
2021-03-03 20:46 ` [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab Tom Tromey
2021-03-03 22:27 ` Wei-min Pan via Gdb-patches
2021-03-03 20:49 ` [PATCH,V2 3/5] CTF: handle forward reference type Tom Tromey
2021-03-03 22:01 ` Wei-min Pan via Gdb-patches
2021-03-02 12:23 ` [PATCH,V2 2/5] CTF: set up debug info for function arguments Lancelot SIX via Gdb-patches
2021-03-02 18:12 ` Wei-min Pan via Gdb-patches
2021-03-03 20:38 ` Tom Tromey
2021-03-03 21:58 ` Wei-min Pan via Gdb-patches
2021-03-03 20:41 ` Tom Tromey [this message]
2021-03-03 20:37 ` [PATCH,V2 1/5] CTF: fix incorrect function return type Tom Tromey
2021-03-03 21:57 ` Wei-min Pan via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blc0ynp5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox