From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hPkwAf/tkmBXCwAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 15:11:59 -0400 Received: by simark.ca (Postfix, from userid 112) id EB19D1F11C; Wed, 5 May 2021 15:11:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C48E1E54D for ; Wed, 5 May 2021 15:11:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C87E0385482A; Wed, 5 May 2021 19:11:57 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.104]) by sourceware.org (Postfix) with ESMTPS id 50EB3385482A for ; Wed, 5 May 2021 19:11:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50EB3385482A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 5A488D00D8 for ; Wed, 5 May 2021 14:11:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eMvqlRy9gw11MeMvqlhy9G; Wed, 05 May 2021 14:11:38 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xiGyFS4UFQDvoTkXurTbsg/OLd39rZrADShMlNELfw0=; b=QCBYcohEIOq816SDrq1dQsDkp5 ZMkNCE7vy+17EEjmwEuSb97oGkIJcY26KPnTzUvDoV63T8l0Mi++zyTcqHnzzHy0tQn3iT8MixhTZ 6dvpglWyxlSxAD2OujyZ2chof; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:60762 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1leMvq-000qyQ-0R; Wed, 05 May 2021 13:11:38 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH] gdb/guile: perform tilde expansion when sourcing guile scripts References: <20210505174058.2135104-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Wed, 05 May 2021 13:11:37 -0600 In-Reply-To: <20210505174058.2135104-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 5 May 2021 18:40:58 +0100") Message-ID: <87bl9pq9li.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1leMvq-000qyQ-0R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:60762 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> This is because the path is not tilde expanded. In contrast, when Andrew> sourcing a .py or .gdb script the path is tilde expanded. Andrew> This commit fixes this oversight, and allows the above source command Andrew> to work as expected. It seems a little strange to me that each extension language must do this, rather than the caller doing it. Andrew> + gdb::unique_xmalloc_ptr msg Andrew> + (gdbscm_safe_source_script (full_path.c_str ())); I suppose gdbscm_safe_source_script could return a unique_xmalloc_ptr, and this could just use the '=' form. Tom