Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2 2/2] Forward mouse click to python TUI window
Date: Wed, 02 Jun 2021 12:49:28 -0600	[thread overview]
Message-ID: <87bl8op0ef.fsf@tromey.com> (raw)
In-Reply-To: <20210529142636.11432-2-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 29 May 2021 16:26:36 +0200")

>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

Hannes> If the TUI window object implements the click method, it is called for each
Hannes> mouse click event in this window.

Thank you for doing this.

Hannes> +@defun Window.click (@var{x}, @var{y}, @var{button})
Hannes> +This is called on a mouse click in this window.  @var{x} and @var{y} are
Hannes> +the mouse coordinates inside the window (0-based), and @var{button}
Hannes> +specifies which mouse button was used.
Hannes> +@end defun

I think documenting that the button is 1-based would be good.

Otherwise, this looks good to me.

Tom

  parent reply	other threads:[~2021-06-02 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210529142636.11432-1-ssbssa.ref@yahoo.de>
2021-05-29 14:26 ` [PATCHv2 1/2] Initial TUI mouse support Hannes Domani via Gdb-patches
2021-05-29 14:26   ` [PATCHv2 2/2] Forward mouse click to python TUI window Hannes Domani via Gdb-patches
2021-05-29 14:49     ` Eli Zaretskii via Gdb-patches
2021-06-02 18:49     ` Tom Tromey [this message]
2021-06-02 18:48   ` [PATCHv2 1/2] Initial TUI mouse support Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl8op0ef.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox