From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hgOpKVC0WWIGcQAAWB0awg (envelope-from ) for ; Fri, 15 Apr 2022 14:07:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 9574D1F327; Fri, 15 Apr 2022 14:07:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEA591ED17 for ; Fri, 15 Apr 2022 14:07:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6FCD53857366 for ; Fri, 15 Apr 2022 18:07:11 +0000 (GMT) Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 85507385842B for ; Fri, 15 Apr 2022 18:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85507385842B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id EADA010048358 for ; Fri, 15 Apr 2022 18:06:58 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id fQLSnQp19b2WGfQLSnkBEK; Fri, 15 Apr 2022 18:06:58 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Uq2mi88B c=1 sm=1 tr=0 ts=6259b442 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=pkaaoLnDXlekbukzt7oA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P8usZBTwTbmZbpqINlHGz0xNQJ6aF+iIxxcWcen+A1c=; b=XO/Bnrn4KnBy/HvT7nRGMi1ZzE YLoK3JeyMgtq+1jEZdwQDp+giocMrZ1LYtHA0/Hu5zPAoVnn/erunwHG5ZtOSdybjdyCbuIhhUnGn hvTwFAgrctbOxwRO7uv1/UA+L; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55580 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfQLS-001CpZ-93; Fri, 15 Apr 2022 12:06:58 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Subject: Re: [PATCH v2] gdb/Python: Added ThreadExitedEvent References: <20220412090315.1142824-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Fri, 15 Apr 2022 12:06:57 -0600 In-Reply-To: <20220412090315.1142824-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Tue, 12 Apr 2022 11:03:15 +0200") Message-ID: <87bkx2z0e6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1nfQLS-001CpZ-93 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55580 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Farre via Gdb-patches writes: Simon> Currently no event is emitted for a thread exit. Simon> This adds this functionality by emitting a new gdb.ThreadExitedEvent. Simon> It currently provides three attributes, the LWP id, the TID and Simon> the GLOBAL NUM. A case could be made to also add the per-inferior Simon> number, but, I wasn't sure if it is actually any useful. Simon> Added info to docs & the NEWS file as well. Eli will have to review the docs, unless he already has. Simon> + if (!evregpy_no_listeners_p (gdb_py_events.thread_exited)) Simon> + { Simon> + ptid_t ptid = tmp->thread_obj->thread->ptid; Simon> + int global_num = tmp->thread_obj->thread->global_num; Simon> + if (emit_thread_exit_event (ptid, global_num) < 0) Simon> + gdbpy_print_stack(); Space before open paren here. Simon> +emit_thread_exit_event (ptid_t ptid, int global_num) Simon> +{ Simon> + gdbpy_ref<> thread_event_obj = create_event_object (&thread_exited_event_object_type); Simon> + if (thread_event_obj == NULL) We're using 'nullptr' in new code. I'm curious why the event has various attributes of the thread object but not a reference to the thread object itself. That seems a little odd. Simon> + append GDBFLAGS " -ex \"set non-stop on\"" Is this really needed? Otherwise, this patch looks good. Thank you for doing this. Tom