From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ckj2NCWW5WehrBwAWB0awg (envelope-from ) for ; Thu, 27 Mar 2025 14:17:09 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UJ2nSSi9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CA56A1E0C3; Thu, 27 Mar 2025 14:17:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A8BA1E0C0 for ; Thu, 27 Mar 2025 14:17:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6CD38382E69D for ; Thu, 27 Mar 2025 18:17:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CD38382E69D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UJ2nSSi9 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id D5467382E680 for ; Thu, 27 Mar 2025 18:15:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5467382E680 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5467382E680 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743099334; cv=none; b=FBRY4D2qSl8AUm5TwKNH2t+EMjW1jRzpluPBk5IBFyoP46+/XMhk13WTy94Rb8XpWLAQpJzkJYFat7yy/SbLI5o6cNDQPrEfzaAjTOvHHwHYw316TBzuVYyH/uUamsi7f99bLA9gqYdShu2rwTcvCjtD50kgdrgfpFNU3V6dtDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743099334; c=relaxed/simple; bh=EyOD15O715Nc29xniy2VUGqq/Tjad+TDsNB8i0H4a/0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=H7VFJMOZx7wzOTmWT260tKJxhdAE54zS0w/h9LMuplI0xXu4n5rasc3Pzi1nkEIO804lYFu0ZyR09dgSf2N6kiwo2ZsySmccovDZnu4EeRmcv/HSxLICOKc3neF/vEMrwdjlL3yEZRRlRjjOEz8M1tUUKSR9b5WVnfAza56kQWk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5467382E680 Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id xpektKkEJVkcRxrlOtX1PN; Thu, 27 Mar 2025 18:15:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xrlNtfnsiJ4PgxrlOt07NR; Thu, 27 Mar 2025 18:15:34 +0000 X-Authority-Analysis: v=2.4 cv=ZaLWNdVA c=1 sm=1 tr=0 ts=67e595c6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=LjHFePmFSxNESrk_GBsA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/TpiW+aEkRS3HLDI0mGirW1BXFys8unDuInTlChoyTI=; b=UJ2nSSi95HPFad2VbBhrw85mjs YI1dcwU/FeVEIDAc41v9lRNsDHmSM/cZHgOk4rHiGTyp11y3DD2cER52VOw126yWSfX7Z/zu3YoKK tpFoIRce2++o6uAhRHNhcokS7; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:45168 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1txrlM-00000000qOc-44ML; Thu, 27 Mar 2025 12:15:33 -0600 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gstack issues In-Reply-To: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> (Keith Seitz's message of "Thu, 27 Mar 2025 08:54:50 -0700") References: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> X-Attribution: Tom Date: Thu, 27 Mar 2025 12:15:31 -0600 Message-ID: <87bjtmuypo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1txrlM-00000000qOc-44ML X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (bapiya) [97.122.123.18]:45168 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfD1DR3c2KTrAg/flqv2/yYJ06WySXzajuDdy4i23qivaDjM9NnrP7a0DrFv3320pRKuQ+zUbmjLZAwpEQsHOJO7oRzYzhmeVaZH3Jw/Iz5h+qS3hulf1 EGN8xtT3Y++MAf5W40zTXbZmmNZSgSDtAp0TL0vbIJed+4G7WM2blF5nuixZvXTDN5LNxqXqNcwfEh/YYt9PXpWy8fH4l6r4fOE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Keith" == Keith Seitz writes: Keith> With commit fb2ded33c1e519659743047ed7817166545b6d91, I added Keith> Fedora's gstack script to gdb. Some issues have arisen since Keith> then, and this patch addresses those issues: Keith> . As Sam James recently noted[1], PKGVERSION and VERSION Keith> need to be quoted. Keith> . A Fedora user reported the misuse of --readnever, which Keith> causes gstack to omit filename and line number information in the Keith> backtrace[Red Hat BZ 2354997]. Makes sense to me. Thanks for doing this. Approved-By: Tom Tromey Tom