From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Cc57EeyYbGg2Yi4AWB0awg (envelope-from ) for ; Tue, 08 Jul 2025 00:05:00 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SErjFLVq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2E4F31E11C; Tue, 8 Jul 2025 00:05:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 261C01E0C2 for ; Tue, 8 Jul 2025 00:04:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1D0D385B83C for ; Tue, 8 Jul 2025 04:04:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1D0D385B83C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SErjFLVq Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id ABE59385B83C for ; Tue, 8 Jul 2025 04:04:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABE59385B83C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ABE59385B83C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751947464; cv=none; b=nM1wQns1Zw7el8226zJc0uKBZB73FVC4rAIZAp2vAFTLHlwkkR00HUlCM458w4Q+AdSmqoFFo9uAM/CfFpFAAgMGONgG3BgDZclGYAD8jQlzrBdC3QI/ujqFeDQFBVOY6Uyi7DaUIovsS3xm/wm/WrMC5l+Hwvud09AV8Pah42w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751947464; c=relaxed/simple; bh=iSS4ReybShK1ESiPPYRFyPZIo2cuogf8N9SacUJMk64=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=p9lwsR7S7LM2bmu2vRHHRvDdmYTuA1K2N5EMZfprQw0WfKPyA0tDWeVEajn8M/ZC+vfGmwRZUnGXQZBUaI6R/Y4OhvuKcmt3tnL//rSX+WSTy6QlBRaDa13F75722dA4sn1fbuNTx00kkamWT+4EeIsSNLIZ0m3+R6L+Uw2QRig= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABE59385B83C Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-6facf4d8e9eso42776286d6.1 for ; Mon, 07 Jul 2025 21:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751947464; x=1752552264; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ggjRDwlnOVAyKX+vqfvia4QsNmN+tu7Qs3QeWmGpbtI=; b=SErjFLVqHCDe4u76SJsXd8RWIuF2Px9FX3O7pUgBBOfnROuWetFZ/kHGuMcLDrY6XP kkQzBzpd44Unp+XHh5/Vf+Wchm6epbD1EKQp1+huPxgasUmoDi5f4tkZBGxHQeJd5ovo Dhq8GsyVdxvdNSUwRfImVvBRGoQhV1ULbtXos0HZAnG3FOvl3PYr7IQOa1qD/UkRkhpR 48RpuqUmzwSEDxqsd7X/z/JIpr0LzHY7MPhSNAfRK6UivNxdXzMmwHmHaLbXBmct+zh8 cav84+vLmeSH6YeGV6WM1pSybfQS+WcMHNCls/KDsF3LgoMamMpkE4yY5+q9u80xfQd0 k/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751947464; x=1752552264; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ggjRDwlnOVAyKX+vqfvia4QsNmN+tu7Qs3QeWmGpbtI=; b=G0/nDNJiEnhubYW5yMwYiNEQi0nAwdL7xFmgXM+NCY+LZAsfb5PItcklEZn0tQX7OU 4ITTCcB+4tELSzuCVv+CLVpnIZh5WEjaAi3Xon3lhoB+nx71IMawJL9LrFUdwNycY7sS zxufy95tRT6onxsx+xwPPxohELrUEqlTH/qAQhs66F5pfULnZTHaoUTgHB+XLivpDKfK +LbiRnXkLs7oUQ/ijOhxhF1Pslqqx3vv8yuNjtzFxWpyo3DSiVv8/pRrxvKUOGqDPMS9 hud3/H+VnxKzceFf3Eu89tbc7PXRefk6KuJDDhJLX41knqBTvSyp/4GxJwhfdfsvepBE 6fhA== X-Gm-Message-State: AOJu0Yy1hh+8rYLuIG0T81vZLO2tsJV6UxBHD8UnF5hQfpw11WGOfBCJ erJZx+i7zQuob7BZe3vI6hY1DWhk8kpTYQ7PIwGGW6FRFfAeYrp8MqElddHyQgV1bmKgzdB1gTd 2wEXH X-Gm-Gg: ASbGncvnsi8Am6QVcnxqK54IFpkP4Vm3RZvi8J79umPi0QK4aoEgNAPs9+LKGLT9ngY 3H034pLRdxQLY6DSHRmEHM0EJOQMTAubUY1z3/y+cQFvHy1vWct45nW+tiqNqgOEK2hTLto5MMO 9B595wGEsBf9v7pllbnfhEcq2d9yD5Z8isHBIChTKU533/bl4OnW/PtSIfj8U+dfZ3V4BH0oQeD c3eP3w9C0Z8J1XShK1lKgRNC30xG8O0FVem4rVrG1OAKur7XFgsn856VIk9jwwgLKmy0Au9zsIH FqpYMZ3fkcpUFhjc7uMIqCRS8KBDVTNFwX5hbBKR2Ro61uBOOweCv4YgCFKr+kky1pVTnlo= X-Google-Smtp-Source: AGHT+IH7Po+LTWXPrFr5QL2t46Zt1V5Q6qcZr+CfAV/CFU3JfmTdJsYPAvOAg8qpLKez5Y02nYw4+g== X-Received: by 2002:a0c:f094:0:20b0:702:b7c8:674b with SMTP id 6a1803df08f44-702c8bcec1bmr148957606d6.33.1751947463997; Mon, 07 Jul 2025 21:04:23 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:eed:782a:14c2:417a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4cc7529sm72601106d6.20.2025.07.07.21.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 21:04:23 -0700 (PDT) From: Thiago Jung Bauermann To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org, Markus Metzger Subject: Re: [PATCH v2 07/47] gdb, gdbserver, gdbsupport: add 'device' tag to XML target description In-Reply-To: <20241213-upstream-intelgt-mvp-v2-7-5c4caeb7b33d@intel.com> (Tankut Baris Aktemur's message of "Fri, 13 Dec 2024 16:59:24 +0100") References: <20241213-upstream-intelgt-mvp-v2-0-5c4caeb7b33d@intel.com> <20241213-upstream-intelgt-mvp-v2-7-5c4caeb7b33d@intel.com> User-Agent: mu4e 1.12.11; emacs 30.1 Date: Tue, 08 Jul 2025 01:04:20 -0300 Message-ID: <87bjpvs4zf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tankut Baris Aktemur writes: > diff --git a/gdb/xml-tdesc.c b/gdb/xml-tdesc.c > index 436c493d4f914eb71a80bcbc08dc2ddd38c72027..61cba42e9eee2ec4cc66e14a120c5bef909e48b0 100644 > --- a/gdb/xml-tdesc.c > +++ b/gdb/xml-tdesc.c > @@ -137,6 +137,65 @@ tdesc_end_compatible (struct gdb_xml_parser *parser, > tdesc_add_compatible (data->tdesc, arch); > } > > +/* Handle the end of a element and its value. */ s/the end/the start/ > +static void > +tdesc_start_device (struct gdb_xml_parser *parser, > + const gdb_xml_element *element, > + void *user_data, std::vector &attributes) > +{ > +void > +print_xml_feature::visit (const tdesc_device *device) > +{ > + if (device == nullptr) > + return; > + > + std::string tmp = " + if (device->vendor_id.has_value ()) > + string_appendf (tmp, " vendor-id=\"0x%04" PRIx32 "\"", > + *device->vendor_id); > + > + if (device->target_id.has_value ()) > + string_appendf (tmp, " target-id=\"0x%04" PRIx32 "\"", > + *device->target_id); > + > + string_appendf (tmp, " family=\"%s\"", device->family.c_str ()); > + string_appendf (tmp, " model=\"%s\"", device->model.c_str ()); For all the string attributes in device: isn't it better to check whether the string is empty and only emit the attribute if it isn't? > + if (device->stepping.has_value ()) > + string_appendf (tmp, " stepping=\"%d\"", *device->stepping); > + > + string_appendf (tmp, " name=\"%s\"", device->name.c_str ()); > + string_appendf (tmp, " pci-slot=\"%s\"", device->pci_slot.c_str ()); > + string_appendf (tmp, " uuid=\"%s\"", device->uuid.c_str ()); > + > + if (device->total_cores.has_value ()) > + string_appendf (tmp, " total-cores=\"%ld\"", *device->total_cores); > + > + if (device->total_threads.has_value ()) > + string_appendf (tmp, " total-threads=\"%ld\"", *device->total_threads); > + > + if (device->subdevice_id.has_value ()) > + string_appendf (tmp, " subdevice-id=\"%d\"", *device->subdevice_id); > + > + string_appendf (tmp, "/>"); > + add_line (tmp); > +} > + > /* See gdbsupport/tdesc.h. */ > > void > diff --git a/gdbsupport/tdesc.h b/gdbsupport/tdesc.h > index c9e7603369cbf986187908c2d1f8fbe35a0dc02d..29de4d231f16667c8297bcbe403f683c30a28762 100644 > --- a/gdbsupport/tdesc.h > +++ b/gdbsupport/tdesc.h > @@ -26,6 +26,7 @@ struct tdesc_type_builtin; > struct tdesc_type_vector; > struct tdesc_type_with_fields; > struct tdesc_reg; > +struct tdesc_device; > struct target_desc; > > /* The interface to visit different elements of target description. */ > @@ -56,6 +57,9 @@ class tdesc_element_visitor > > virtual void visit (const tdesc_reg *e) > {} > + > + virtual void visit (const tdesc_device *e) > + {} > }; > > class tdesc_element > @@ -315,6 +319,84 @@ struct tdesc_feature : tdesc_element > > typedef std::unique_ptr tdesc_feature_up; > > +/* The device information in a target description. */ > + > +struct tdesc_device : tdesc_element > +{ > + tdesc_device () > + { > + family = "-"; > + model = "-"; > + name = "-"; > + pci_slot = "-"; > + uuid = "-"; Why aren't the strings left empty? > + } -- Thiago