From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XhBnNa+ByWgcxAYAWB0awg (envelope-from ) for ; Tue, 16 Sep 2025 11:26:39 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VWVsGqlH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CC1E61E04C; Tue, 16 Sep 2025 11:26:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7F691E04C for ; Tue, 16 Sep 2025 11:26:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C1D2385701B for ; Tue, 16 Sep 2025 15:26:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C1D2385701B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VWVsGqlH Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id A97E33857359 for ; Tue, 16 Sep 2025 15:23:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A97E33857359 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A97E33857359 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758036218; cv=none; b=SigsP5zlf3BDxZ4ehFbiUzvGgAcUTkaH0zgatO1eqM2SPzqX9or3G/xlNZgrLazT0OKhLjxfPPW45PibIbbLpWuSqLcDd1SXmZH43TpoiWImuPK7hJDR+/SNEszGDaZz1Pc18+xDU90gp4biZeLOtLm4ZyMkyg3oFQD7b4pxJ9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758036218; c=relaxed/simple; bh=rBSp96UuOvIy+CXjNc3Yp6OkKQmUeBPaNhE0lT/sFJc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kNupnhILBy67P3Rwwpl+eUvYmG0AbdBgpfeVG2HdznLdZY2A1NMAo+T24XVZwbhYrCfRO9tR4/XENE93ychRvZJDIP+FlKHk0UcrPVxDLwnWJRcrI1xrx5frKIDKNPu2JnubTL9XPmNBknoMiF90Ydk5K25O+jbZP4SoMb8DiiQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A97E33857359 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-887745ee814so185557839f.3 for ; Tue, 16 Sep 2025 08:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1758036218; x=1758641018; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UJGGW30A2Y7JFegw2WhqmPDq3FQz/zW+Cv9gTkkZFXQ=; b=VWVsGqlHROcmFFepkD+o3JG5PFN5qW88ui4k8UL4lnj8aX1dpK+h5yA7yjlWTny8Vl cEgryN7loS/86Bmu2+ki0V2sUY/hzk2aASQdZC4JjciK+BBrocG96xr1DOXA3ZvhFhqw YVSPBP2zl/lUtzLM2s2bwUIhQOCvudoWRcB2gud5AmIAAT8cCX/IPtngyHCKGLME+4ib +pYyV+MZfWLFgTPyDTpm09ag6SD4ZvlkM/P5OZwr0JBWeisR2hEK5ZHW6zvPFrCbk61i NZrQHEiXeMsi8+ygV8c+le9woTn/hbHngiIUNL4ikqw4d8CxplGzpR45ufPi2lcXpbDe n3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758036218; x=1758641018; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UJGGW30A2Y7JFegw2WhqmPDq3FQz/zW+Cv9gTkkZFXQ=; b=w1rbUtI01ixBUc6IN9WyUSscRVVe0TBR2oaW/ZEWSt562o4bkU2Ed5lONsimsz2ifO LEUb1b9e1OzOMQk8FaFK0e+c3QBfADQQpnDTQK8KwsTrMtj9wNmyi5VN4GKWukCV6Gre MrQg9bEk9Sc8TUlH745H+2eiQL6WzqWySUvio7md5TYPPGTil5TysXyXrk95VtuBaavj UM/CJhcOM2P7SkGyZzj4OjJXrIu4kcbp0Ns5k9yI++WZ3Gt61jlTVrkHBpz4XLg1w4WA Ke/skxfJ6U1bQt6MuR2PI9Twhwt1DBM0p7dyvJ3rpBk3J6CY/JHGyKbHhe3pVTj4Zd7B m3GA== X-Gm-Message-State: AOJu0YwZzOz8yEdMLv9iO3GsC2jhOzWiyTLHtX6qhx9ifpQcdHc9vH2F GGSxOhcGO3gKqc+CjaE7HU3K+wlHdndHzcnaTLHQTikoLxinD8WgcV4NsCj79Hc7yw== X-Gm-Gg: ASbGncuT/zqrsM6E93rScV13UxkC3sxc0F4O2rjqrHE26F4tvY+4idMKgWBFlAz7gI0 AR0EWywjhlTpa6j3WryZ5PYFzW0CjTOsONluHtFizWJBMqtCVkKurOWWqZ6HvWsMK4w9vki2OCK uEzfvVvkJIDinDyB4tlCiW0G32ckr4ZkrkuWQrcbX6GAIPmmq7JKDwtheZeH8+DWAIWlQ9Gw2Np 6y850Cvrrse4AwrN3vIK4kDD4i7J9rfIkAa4GmKpqgPeXehTQNu9VmJKaCZ3nhtZK/rVs6FZHVK Ic1C8zvUI2BzTF63+MWVBTsIAeQ9OGn7N3qOMnp4A2vnKSzQ3Pt4gdWykZNdv2iqaOVMM5N0ib+ aJuWHh3O6NOjl2KpC+WBxv5bNfjZnlUryHua6IVGz3A== X-Google-Smtp-Source: AGHT+IGCU12GtDTG+JZRbIhPAqmQohsTZRis2DExXQ5U2GA9qqAOKg84ojqceHTERjqBSX2Y/KsQKQ== X-Received: by 2002:a05:6602:1690:b0:893:a914:6082 with SMTP id ca18e2360f4ac-893a914778emr663242739f.3.1758036217666; Tue, 16 Sep 2025 08:23:37 -0700 (PDT) Received: from bapiya (97-122-110-68.hlrn.qwest.net. [97.122.110.68]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8949b5f911fsm91873439f.6.2025.09.16.08.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 08:23:37 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v2] Treat attributes as code in DWARF assembler In-Reply-To: <20250908154930.822046-1-tromey@adacore.com> (Tom Tromey's message of "Mon, 8 Sep 2025 09:49:30 -0600") References: <20250908154930.822046-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 16 Sep 2025 09:23:36 -0600 Message-ID: <87bjnamnev.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom Tromey writes: Tom> The DWARF assembler treats the 'children' of a DIE as plain Tcl code, Tom> evaluating it in the parent context. Tom> I don't recall why, but when I wrote this code, I didn't do the same Tom> thing for the attributes. Instead, there I implemented a special Tom> syntax. I was looking at this today and wondered why I didn't just Tom> use ordinary evaluation as well. Tom> This patch implements this idea. I'm checking this in now. I rebased it and re-ran the regression tests. And, I grepped the gdb.log to make sure there weren't any new Tcl errors. However, I find this process to be a bit error-prone -- so if you find that I have missed something, please let me know and I will fix it. Tom