From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BjjvFKUs4GgSGB4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 16:05:57 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CxcXfZmm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3F1D91E04C; Fri, 03 Oct 2025 16:05:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE5AA1E04C for ; Fri, 03 Oct 2025 16:05:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 619693858427 for ; Fri, 3 Oct 2025 20:05:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 619693858427 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CxcXfZmm Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 6D6F83857BA7 for ; Fri, 3 Oct 2025 20:05:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D6F83857BA7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D6F83857BA7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521924; cv=none; b=xBW56TQ3r8tSVjYos7jvsau7kxjse4doYXkwJBs/TGE8Smc3J3Myw1oqjDCFSIPoCRq8r5/rsPmU4FZ4r43SSl2zHnI4k2pwgae96MxSyqxNOvEPhTSU6JRc08vSyajUwgYpeMTsB2FJ+lGjckQ8fAEjJnmzQxSp8bIWGbNrbHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521924; c=relaxed/simple; bh=Ffsv7g/R2wZldqhGThprskRpTwZ57PaTk0qhlHFIrA0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eLZxPQVv0Se/K9gKGw/GZLcjhdULKTGLQjdA2BjoM1sw6C3PG9S4+QJl9BOAhQqKNhSLDTEabrxW5G/6R5CTybAI8p4PWsJM18oyjwJjyPVi5iuNOIUo+5ctCnL6agRYyE7ph5eB+g8EL77XVqs0fI+d+Y7diQh9oJUDxGq5RIE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D6F83857BA7 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id 4QmyvyoemZx2i4m1rvQRRz; Fri, 03 Oct 2025 20:05:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4m1qvkFQFtssb4m1rvKqbh; Fri, 03 Oct 2025 20:05:23 +0000 X-Authority-Analysis: v=2.4 cv=Hb8UTjE8 c=1 sm=1 tr=0 ts=68e02c83 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=B92rbvCVDRD8BYSj5GQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lKo/pev9KqMO9m60P/vkfO3JsHuYbYRDph7B7lfskG8=; b=CxcXfZmmDixqyE6ORJn+wPX/B3 lBhMTtFf/0i6puXN/b3fDr+utGMa363ZuZ6IuaMHYXOyOqfQgMRwWFRmjrSPg1viiWh/ywi58eyhO gSWThOuJQ1kysnONunGFIJmsE; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:54234 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v4m1q-000000014Fj-22IH; Fri, 03 Oct 2025 14:05:22 -0600 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/9] gdb: Refactor 'stack.c:print_frame'. In-Reply-To: <20250923111842.4091694-3-christina.schimpe@intel.com> (Christina Schimpe's message of "Tue, 23 Sep 2025 11:18:35 +0000") References: <20250923111842.4091694-1-christina.schimpe@intel.com> <20250923111842.4091694-3-christina.schimpe@intel.com> X-Attribution: Tom Date: Fri, 03 Oct 2025 14:05:21 -0600 Message-ID: <87bjmn69a6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1v4m1q-000000014Fj-22IH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:54234 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGGUD6cP1ILm9gdsurn9Rnl/PX1KfYMpCz5dBYOrXXxtdNw+Tr08l6olJOttWG1lfdAm3h9cV/rQgVm7WsnsuL0eNNAldoixVZAvqv14/DHGC9tBMMis hVy6UBdp08xEsc/ZfK8omXB6Egb9HENXBm8FovTY0EXZYRYt75tMO/O9cx2BjjWBP61lFpc/NCYP1L7pyS/MJWWdf3YGotp0/JI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Christina" == Christina Schimpe writes: Christina> Refactor the function 'stack.c:print_frame' by introducing several Christina> small functions. Christina> The functions will also be used in a later patch "gdb: Implement Christina> 'bt shadow' to print the shadow stack backtrace." Thanks. Christina> +static void Christina> +print_funname (ui_out *uiout, Christina> + gdb::unique_xmalloc_ptr const &funname) Christina> +{ Christina> + annotate_frame_function_name (); Christina> + string_file stb; Christina> + gdb_puts (funname ? funname.get () : "??", &stb); Christina> + uiout->field_stream ("func", stb, function_name_style.style ()); Not really your problem, but using string_file here seems like overkill. This would be better as plain field_string using funname directly. anyway, Approved-By: Tom Tromey Tom