Re: [PATCHv2 3/3] gdb/python: add Corefile.mapped_files method

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> On 10/7/25 16:38, Andrew Burgess wrote:
>> Andrew Burgess <aburgess@redhat.com> writes:
>> 
>>>
>>> Thanks for the diagnostic help.  I'll work on improving the test to try
>>> and catch these cases.  If that works, then we might be able to adopt
>>> this to help with other tests.  Keeping this in mind, I'll add helper
>>> functions to lib/gdb.exp.
>> 
>> Hi Tom,
>> 
>> At your leisure, could you check that the patch below resolves the FAIL
>> you reported please.
>> 
>
> Hi Andrew,
>
> on Leap 15.6, yes.
>
> On Tumbleweed, unfortunately no.

<snip>

> (gdb) PASS: gdb.python/py-corefile.exp: test mapped files data: capture Python based mappings data
> shell diff -s /data/vries/gdb/tumbleweed-20251005/build/gdb/testsuite/outputs/gdb.python/py-corefile/py-corefile-out-1.txt /data/vries/gdb/tumbleweed-20251005/build/gdb/testsuite/outputs/gdb.python/py-corefile/py-corefile-out-2.txt
> Files /data/vries/gdb/tumbleweed-20251005/build/gdb/testsuite/outputs/gdb.python/py-corefile/py-corefile-out-1.txt and /data/vries/gdb/tumbleweed-20251005/build/gdb/testsuite/outputs/gdb.python/py-corefile/py-corefile-out-2.txt are identical
> (gdb) PASS: gdb.python/py-corefile.exp: test mapped files data: diff input and output one
> show-build-ids
> Objfile Build-Id                          Core File Build-Id                        File Name
> 91c6abb593a519ecd18e543eaac25f913999b230  91c6abb593a519ecd18e543eaac25f913999b230  /data/vries/gdb/tumbleweed-20251005/build/gdb/testsuite/outputs/gdb.python/py-corefile/py-corefile
> Python Exception <class 'KeyError'>: 'corefile'
> Error occurred in Python: 'corefile'

It looks like there's an objfile discovered via
Inferior.progspace.objfiles(), which doesn't correspond to a file mapped
into the core file.  FYI, I only consider objfiles that are _actual_
files, so ignore things like [vdso], etc, and I only consider objfiles
with a build-id.  I figured that everything meeting this specification
had to be something that would appear in the core file...

The patch below will make the show-build-ids command a little more
resilient, when a file is missing it'll print "missing" in the column
now, rather than throwing the KeyError.

My guess is we'll find the same file under different names maybe?

Thanks,
Andrew



---

diff --git i/gdb/testsuite/gdb.python/py-corefile.py w/gdb/testsuite/gdb.python/py-corefile.py
index 5c8ee7b2f0c..01665ef0395 100644
--- i/gdb/testsuite/gdb.python/py-corefile.py
+++ w/gdb/testsuite/gdb.python/py-corefile.py
@@ -110,7 +110,7 @@ class ShowBuildIds(gdb.Command):
                 continue
             p = pathlib.Path(o.filename).resolve()
             b = o.build_id
-            path_to_build_id[p] = {"objfile": b}
+            path_to_build_id[p] = {"objfile": b, "corefile": "missing" }
             if len(b) > longest_build_id:
                 longest_build_id = len(b)
 
@@ -125,6 +125,8 @@ class ShowBuildIds(gdb.Command):
 
             if p in path_to_build_id:
                 path_to_build_id[p]["corefile"] = b
+            else:
+                path_to_build_id[p] = {"objfile": "missing", "corefile": b }
 
         format_str = (
             "%-" + str(longest_build_id) + "s  %-" + str(longest_build_id) + "s  %s"