Re: [PATCH v3 9/9] gdb: remove psymtab.{c,h}

Eli Zaretskii
2026-02-28T10:19:14Z

> From: Simon Marchi <simon.marchi@efficios.com>
> Cc: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Fri, 27 Feb 2026 22:51:56 -0500
>
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> The last user of psymtabs has been changed not to use them, remove them.
>
> Update the tests minimally to avoid introducing failures (mostly due to
> tests using the removed maintenance commands). There are still a lot of
> references to partial symtabs in the comments or test names. There are
> probably some tests that are just not relevant anymore. It would be quite
> difficult to do this job all at once, we can clean this up little by
> little.
>
> Update the docs to remove references to partial symbols/symtabs.
>
> Mention the removal of the maintenance commands in NEWS.
>
> Change-Id: I58ae48c30e0303bcaa48298146d69fb8f059cb32
> ---
> gdb/Makefile.in | 2 -
> gdb/NEWS | 8 +
> gdb/doc/gdb.texinfo | 95 +-
> gdb/psymtab.c | 1575 ----------------------
> gdb/psymtab.h | 691 ----------
> gdb/testsuite/gdb.ada/maint_with_ada.exp | 2 -
> gdb/testsuite/gdb.base/check-psymtab.c | 28 -
> gdb/testsuite/gdb.base/check-psymtab.exp | 26 -
> gdb/testsuite/gdb.base/main-psymtab.exp | 38 -
> gdb/testsuite/gdb.base/maint.exp | 96 +-
> gdb/testsuite/gdb.base/readnever.exp | 4 -
> gdb/testsuite/lib/gdb.exp | 22 -
> 12 files changed, 38 insertions(+), 2549 deletions(-)
> delete mode 100644 gdb/psymtab.c
> delete mode 100644 gdb/psymtab.h
> delete mode 100644 gdb/testsuite/gdb.base/check-psymtab.c
> delete mode 100644 gdb/testsuite/gdb.base/check-psymtab.exp
> delete mode 100644 gdb/testsuite/gdb.base/main-psymtab.exp

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>