Re: [RFC PATCH 1/8] gdb/ctf: add debug logging in ctfread.c

Simon Marchi
2026-02-03T16:22:40Z

>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index fa6e7ca61219..af04fa1e67ae 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -91,6 +91,10 @@ show progress-bars enabled
>> content, to be disabled (the set command), or to see if
>> progress-bars are currently enabled or not (the show command).
>>
>> +set debug ctf on|off
>> +show debug ctf
>> + Print debug messages about CTF reading.
>> +
>> * Changed commands
>
> This part is okay.
>
>> +@item set debug ctf
>> +@cindex CTF debug messages
>> +Turns on or off display of debugging messages related to reading CTF
>
> Please always put the indexing commands _before_ the @item line to
> which they refer. This way, following the index entry in the Info
> reader will place the cursor on the @item line, not after it.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

Thanks for the review.

I will make that change and apply your Reviewed-By. This patch will
likely be re-sent as part of a non-RFC series.

Btw, I just copy pasted the doc for some other "set debug" command. It
seems like there are a lot where the @cindex follows the @item. Would
you like me to fix those?

Simon