Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs

Tom Tromey
2026-03-04T19:33:16Z

Simon> Change the expanded_symbols_functions quick functions type to hold and
Simon> use a list of compunit symtab to search.

Simon> Right now the sole user of expanded_symbols_functions is JIT. Update it
Simon> to keep a vector of compunits as they are finalized, and pass this
Simon> vector to the expanded_symbols_functions object.

Tom> I think this is a good direction but this patch isn't quite complete.
Tom> The issue is that there are still a handful of spots in gdb that loop
Tom> over all compunits. But with this change, these spots will skip some
Tom> compunits.

It took me a while but I finally realized that the new vector is in
addition to the objfile's compunits.

This seems kind of ugly to me but OTOH it doesn't have the problems I
ascribed to it.

Tom