Re: [RFC PATCH 1/8] gdb/ctf: add debug logging in ctfread.c

Simon Marchi
2026-02-03T20:40:18Z

On 2026-02-03 11:37, Eli Zaretskii wrote:
>> Date: Tue, 3 Feb 2026 11:21:50 -0500
>> Cc: gdb-patches@sourceware.org, nick.alcock@oracle.com, weimin.pan@oracle.com
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> Btw, I just copy pasted the doc for some other "set debug" command. It
>> seems like there are a lot where the @cindex follows the @item. Would
>> you like me to fix those?
>
> Yes, please. They are all mistakes.

Ok, and just to make sure I am headed in the right direction, would
these changes be good? This rule applies to all the @*index commands,
such as @findex?

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index d39fa02b7119..5e27d52e1d26 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -982,48 +982,48 @@ than @samp{-}, though we illustrate the more usual convention.)
@c it.

@table @code
-@item -symbols @var{file}
-@itemx -s @var{file}
@cindex @code{--symbols}
@cindex @code{-s}
+@item -symbols @var{file}
+@itemx -s @var{file}
Read symbol table from file @var{file}.

-@item -exec @var{file}
-@itemx -e @var{file}
@cindex @code{--exec}
@cindex @code{-e}
+@item -exec @var{file}
+@itemx -e @var{file}
Use file @var{file} as the executable file to execute when appropriate,
and for examining pure data in conjunction with a core dump.

-@item -se @var{file}
@cindex @code{--se}
+@item -se @var{file}
Read symbol table from file @var{file} and use it as the executable
file.

-@item -core @var{file}
-@itemx -c @var{file}
@cindex @code{--core}
@cindex @code{-c}
+@item -core @var{file}
+@itemx -c @var{file}
Use file @var{file} as a core dump to examine.

-@item -pid @var{number}
-@itemx -p @var{number}
@cindex @code{--pid}
@cindex @code{-p}
+@item -pid @var{number}
+@itemx -p @var{number}
Connect to process ID @var{number}, as with the @code{attach} command.

Simon