Re: [PATCH v3 0/9] Make CTF reader build full symtabs, get rid of psymtab

Simon Marchi
2026-03-09T18:58:05Z

On 3/4/26 2:33 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> This is v3 of:
> Simon> https://inbox.sourceware.org/gdb-patches/20260217195329.3833518-1-simon.marchi@polymtl.ca/
>
> Simon> The change is that the last patch now includes necessary test changes
> Simon> (to avoid regressions), plus doc and NEWS changes.
>
> I read through these & I think this is fine.
> There's one patch where the commit message should be updated.
>
> Assuming I'm correct about the compunit issue -- that the new vector is
> redundant in the sense that compunits also appear on the objfile -- then
> I think this is ok, albeit somewhat unfortunate.
>
> Approved-By: Tom Tromey <tom@tromey.com>

Ok, thanks. I'll push the series, since it seems to be a step forward,
we can always adjust things later.

Simon