From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BzSPNAwpp2kYxRIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 13:31:40 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=a+kVgWOS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B5CBC1E0DD; Tue, 03 Mar 2026 13:31:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1ACEA1E089 for ; Tue, 03 Mar 2026 13:31:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 71F1E4BA23C3 for ; Tue, 3 Mar 2026 18:31:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71F1E4BA23C3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=a+kVgWOS Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 749864BA2E09 for ; Tue, 3 Mar 2026 18:31:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 749864BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 749864BA2E09 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772562673; cv=none; b=Ey1twURR8DV+lvpy9ARqlX4p11tuoWKubnh0AulxFhKF0x1rsJQIfwqyUKkIGrT1sz/yohGjGif6GzKexGcy4f8AyVP/Zq85WfALPe0R3Q1vXjOtlybfWCUXQaEiz40p1sj77IEEwJ8SRhDxosXplV9UT4T8iLm68HeFhL5qL9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772562673; c=relaxed/simple; bh=7g9GIqPZKZMJZx2rvFEVl7foWCYOWzgShqBAxWDBxhg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IZ1ixWW2o01Pp2OXZFHfZznPL6sKOjcBQx8Cho8si0eSHzcLBGA3yfl6b9eRZAN5/+RcU9/20gQZfwZBTslPVTlDRBGdvis65+KldeM60uQn4hB5YmYN2+kGKEBO//83/JWmUNatt9iOcgOkTINbmXpqNoWt2QHHvMB4agHb28w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 749864BA2E09 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id xUCyvwPSOKXDJxUWXvJxVw; Tue, 03 Mar 2026 18:31:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xUVvvRHwYqfpWxUVvvdS6W; Tue, 03 Mar 2026 18:30:35 +0000 X-Authority-Analysis: v=2.4 cv=A55sP7WG c=1 sm=1 tr=0 ts=69a728f1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=LPRzeCG9od7wR1o_2c8A:9 a=dVallt49tk3wT16gAmR6:22 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=orU68ZRV/Ed8dbksTcaHC/UOHP7vwvvW7+ztZjlOZ3M=; b=a+kVgWOSYqcQIIlTql4QCwQvbq xD9EgOAUl3959jBPBHDkozfExBkYPolbe062Zx6/R/d5cu992DUB2LpBCSQFHoikgtAfo31Nhdh20 HNjVdYhjJPm2O0bFyel4STXLb; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:41834 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxUVu-00000001UkJ-3YrA; Tue, 03 Mar 2026 11:30:34 -0700 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v2 8/9] gdb/python: add gdbpy_dict_wrapper:allocate_dict helper In-Reply-To: <20260303161659.397427-9-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 3 Mar 2026 16:16:58 +0000") References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-9-matthieu.longo@arm.com> X-Attribution: Tom Date: Tue, 03 Mar 2026 11:30:33 -0700 Message-ID: <87bjh4rcja.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vxUVu-00000001UkJ-3YrA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:41834 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBkC+Uw/02fKYC6FyVO1OY0NYHjj2LHblr8dQCqkVv1RwEfmrZFdVmTxrGb8sltX5zQfH48PiTX/K/fG5n7XiaF6E4XzQ/nyf02KWGl+GVMPW654wKSN iF7WjiX4/PUawZHi65cDST4oBQL7JOJfT6ysDuOsxyrfocFm5L1DNwMNwl5AOSCz58PQOJH1kvfMvFMz66CIPApWRuk7HoruhLQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > Python extension objects that support __dict__ must inherit from > gdbpy_dict_wrapper, a wrapper class that stores the PyObject > corresponding to the __dict__ attribute. > Currently, management of this dictionary is not centralized, and > each Python extension object implements its own logic to create, > access, and destroy it. > This patch focuses on the allocation of the dictionary, introduces > a new helper function, gdbpy_dict_wrapper::allocate_dict(), and > adapts the existing code to use the helper. > + if (! gdbpy_dict_wrapper::allocate_dict (object)) > return nullptr; gdb style doesn't put a space after '!' in an expression. There's a few instances of this. > + > + template > + static bool > + allocate_dict (gdbpy_ref& self) Space before "&" > + { > + static_assert (std::is_base_of_v > + || std::is_same_v); > + auto *obj = static_cast (self.get ()); > + obj->dict = PyDict_New (); > + return obj->dict != nullptr; It seems to me that if this were a non-static method, then it also would not have to be a template method, like bool allocate_dict () { // maybe? gdb_assert (dict == nullptr); dict = PyDict_New (); return dict != nullptr; } The idea being that inheritance takes care of the details, so this works: gdbpy_ref blah; if (blah->allocate_dict ()) ... Unless we have a case where this is needed for plain gdbpy_ref<>? But based on an earlier patch I would think that's not possible. Tom