From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IFrFI201FmpczB4AWB0awg (envelope-from ) for ; Tue, 26 May 2026 20:06:05 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BhUutKTQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 734F61E024; Tue, 26 May 2026 20:06:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA3291E024 for ; Tue, 26 May 2026 20:06:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C5DC4BA2E28 for ; Wed, 27 May 2026 00:06:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C5DC4BA2E28 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BhUutKTQ Received: from mail-dy1-x1333.google.com (mail-dy1-x1333.google.com [IPv6:2607:f8b0:4864:20::1333]) by sourceware.org (Postfix) with ESMTPS id 449014BA2E15 for ; Wed, 27 May 2026 00:05:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 449014BA2E15 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 449014BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779840340; cv=none; b=fNGT0fn4qsMcaLi9r1uNnmRJP6W0uWSQXSYBn4QybWkxRZsv8Wqe7KX15q/2C7jE3ciECNyYKpBKzty4g8SAPMslo7SJwfGnzUTtkWw0WioplaRC3a9F1/xCcluOYML6BZM2Xkhh8idCeKC3MRQX4m1GQqd2Q8ZpV3lHOL2Us6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779840340; c=relaxed/simple; bh=hrbEZ0dzvKKMKD/X33rfXGj5wd2gwmz3ha3aZDdqJx0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=f4ISf7pbO47fz3TYa1BYWsY53YUOb2YwSmEMmyeaRhXgPxqWA39M1+xlJRmaiA3FWWUjctDz8tNRByI1WY3dKtPWTrCwQzkvxwjQ1qsxNXP/jHyhh4BfzPIY0JBwWIm1MTzEOuF/buFOSaEtMCrG8R8C2cjJGi17FIaZHrb+w4o= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BhUutKTQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 449014BA2E15 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-2f68f3b075fso3122177eec.0 for ; Tue, 26 May 2026 17:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779840339; x=1780445139; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=USuv732q9ZEwXrjMagk7xgyBfTVTh9I2vH1//lu4k70=; b=BhUutKTQdc+rO1IOuliG+PECHRguvJQvVNEfh0WsDJxA2friiL4D7j6VfhDuLBoPMd xjmK4LQc6TYyLi5LRf9gQFwLB/rjKOXh1P1g3l8B9aKLx8Xbfn7qoEk3JiqsteP7iO9q gjIEFGEzdSrZrYDTGrseKWRCYsDigMfS7nGL3xvX5XWKTen/IjREEpIsKW2dbVAgzFR2 HeA2N36fOXX0S+YC1+vnbCE/fOfIV1AVFi+CCC4pcb1OkjM+7r/LFOodvgu/cqXxBLlX S2heM9HjzGcUDBnPXvkcrptqGSBQqo+36tzD0a+6lzoEyRrKQ3xcY4lcm0ZNhD64qnec 2/Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779840339; x=1780445139; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=USuv732q9ZEwXrjMagk7xgyBfTVTh9I2vH1//lu4k70=; b=EsD7UeOWD5+GulR/Y2VyWlKqetsL9lrGO95aNteijVyxiIR7SKSK9r8uW3CyA/bVN/ 8t6OiCT69mJVX0iThwOAn6476jKAV72ET3teIt0o/S5dG+F69u/ceuk3uFjiGSrL8ncS iM6wSkXXzBO6VxNHMYStYqE0C24hHFeTnTs3SxROb44v0UIFAv6B2PQxOsKl2LzOTU4Z zvpzKPWaYBpWH6Bk65SdKPfcudmZHEWpJXCQDruMxS1epq6fIVb+igzlKw2dgfHryvcl 1CZsjCRf5euc6c6UfMF2Gpq+18VGYUDyykyGeVuB6YK1KAZfRuyC55JGqI43/bunjDPM vKTw== X-Forwarded-Encrypted: i=1; AFNElJ+XEsSetmp9OIKTpjjfQ+Eq5ZVyNb9dcAjHzNE/MTubo/rgj5ya+yS/LybpYZgcoxv1g/DFqSe5ZaP7qw==@sourceware.org X-Gm-Message-State: AOJu0YxHoPAg1wtgi2+NmLedzti3WiYDM/qbArG1eKI6i5H56rN7e1I0 AS4YkOo93AKNyO1+lnJ439ntKXcOxSriQShM7B+A5GWW1x71H/6yY5xp8HXXYpMlYu7csjox5ww +WSPH X-Gm-Gg: Acq92OGBmeDeI3BpugEBFNB4oi8w/scJ5jUoNoFymCIUs/A8WqSbUu+XVIauZYXzu/X ZfXB7ovozCjE0ovkfAfrLsbRiOm2SpATR3PGrBZ5ywRNRwr3YMns+zh3CQp1wZwDrhB8Zu6C9Tx Kc/v3pC8OJYVEjINPaMcpox1c779vIFZKCeVn8WcdhaIy5EFeWFpu4Tr5rgspkhIe4lsnPHm+J0 IlciwS0OiVV6xfvGyzV3yg9HIMM3TJkSHGMjFEQ11MbEox1s3qXFoHCEJCoqBJoNFeAy0YplUA6 eFQup9cwhXqk2uxBI1SEpXHMSkqHycZYKBiGMnI9d+5SwZBrQb4heUgzXllfh0RJSwrfXJ2WCKP EUzgmsCdpLtlbvJz1NTM2KAwGhUL9yVwITsq/1p9tbzrqYu8GZxVRC0JAnRNPGtSPaqtnXZUz+n kFW4HxyauwBx/Mg5+96FH6kkfDvTScvCT63fLmy1w02q4O X-Received: by 2002:a05:7301:9bc8:b0:2be:6f30:f2f9 with SMTP id 5a478bee46e88-30449187ebdmr10343615eec.26.1779840339141; Tue, 26 May 2026 17:05:39 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451ef4719sm11621712eec.1.2026.05.26.17.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 17:05:38 -0700 (PDT) From: Thiago Jung Bauermann To: Ezra Sitorus Cc: Guinevere Larsen , , Subject: Re: [PATCH v2 1/4] gdb/aarch64: record/replay support for LRCPC3 In-Reply-To: (Ezra Sitorus's message of "Wed, 27 May 2026 00:36:47 +0100") References: <20260512231707.18123-1-Ezra.Sitorus@arm.com> <20260512231707.18123-2-Ezra.Sitorus@arm.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Tue, 26 May 2026 21:05:36 -0300 Message-ID: <87bje1ogxb.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Ezra Sitorus writes: >> Hi Ezra! I have one tiny comment with regards to the test (that can >> truthfully probably be ignored), but you shouldn't need to send a v3 just to >> fix that. Feel free to add my review tag >> >> Reviewed-By: Guinevere Larsen > Hi! Thanks all for the reviews - I'll address those comments. One question I > have for GDB workflow: do I explicitly need an Approved-By before I can push? Ideally a maintainer will explicitly provide an Approved-By to signal that the patch can be pushed. A single tag is enough even if there are other maintainers/reviewers involved in the discussion, unless the tag is explicitly limited to the tag giver's area of the project. Sometimes instead of a tag an approval is given in a hopefully unambiguous sentence in English to the same effect. The intended meaning of the tags is described in the gdb/MAINTAINERS file. > Or in this case am I waiting on a final approval by Luis or Thiago? For this series, patches 2, 3 and 4 can be committed. For patch 1, a v3 is needed. -- Thiago (he/him)