Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: Tom Tromey <tom@tromey.com>,
	 "Aktemur, Baris" <TankutBaris.Aktemur@amd.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	 Luis <luis.machado.foss@gmail.com>
Subject: Re: [PATCH] GDB: aarch64: Fix inferior function call if GCS is present but disabled
Date: Wed, 22 Jul 2026 16:27:17 -0600	[thread overview]
Message-ID: <87bjby8xtm.fsf@tromey.com> (raw)
In-Reply-To: <87zezivkmd.fsf@linaro.org> (Thiago Jung Bauermann's message of "Wed, 22 Jul 2026 20:23:54 +0000")

Thiago> I found some places in GDB where we do this even though the called
Thiago> function isn't specially marked (e.g., calls to record_stop in
Thiago> gdb/record.c, and call to PyGILState_Ensure in gdb/python/python.c)
Thiago> so ahead with the `(void)`.

Yeah, like with most rules in gdb, there's also violations.

Thiago> I can push a patch removing it if anyone wants.

It's not really that important IMO, just something to note for the
future.

Tom

  reply	other threads:[~2026-07-22 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08  6:03 Thiago Jung Bauermann
2026-07-08  7:50 ` Aktemur, Baris
2026-07-08 19:43   ` Thiago Jung Bauermann
2026-07-21 16:38   ` Tom Tromey
2026-07-22 20:23     ` Thiago Jung Bauermann
2026-07-22 22:27       ` Tom Tromey [this message]
2026-07-19  8:57 ` Luis
2026-07-22 19:59   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjby8xtm.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=TankutBaris.Aktemur@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox