From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jyauG21piGrH9DMAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 11:06:21 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ROnEcZ2C; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A1AA1E033; Fri, 21 Aug 2026 11:06:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44DF41E033 for ; Fri, 21 Aug 2026 11:06:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 474D94BB24CA for ; Fri, 21 Aug 2026 15:06:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 474D94BB24CA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ROnEcZ2C Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 14F934BB1C15 for ; Fri, 21 Aug 2026 15:05:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14F934BB1C15 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14F934BB1C15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787324753; cv=none; b=miVVAqg4d+8i2++EPh4Uu06jqcZ2SVJV4nAd8YKGtLLw8POiE4sRpMrVNiTMddb6PcLMmNj8sOviSs5qJqvZUqp2425Sp/5E7iJbNjn1+V8WZ9UJPm/57rBS21aj2Pc3Tde9U7kW609P0LOcMf4B3qF/XiddZM8Wn9Cz7rgVwxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787324753; c=relaxed/simple; bh=vHMA1JAQYgpDzXATJwlkp8NicaCK7IU3LRL69g22lSs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=o8LNEsy78t5N5Z4xvlP7sv4T2JttS5PDowEWqHLCSNNCicOqqRt7oSkQM15cG4rCLW3FK/5BsjTrHx6pp76MhzRSTQ/SjfeM1POBNYr2Cbl974AZdKbJ9pSBZJXUDCZzlAUhyAkcZsMm+GmH1dkZJduE7I+stcgnqKIIxgLskuM= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ROnEcZ2C reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14F934BB1C15 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id xPiBwJq3wusRSxQoawGjVh; Fri, 21 Aug 2026 15:05:52 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xQoZwpW2C4OZ4xQoZwoq1m; Fri, 21 Aug 2026 15:05:51 +0000 X-Authority-Analysis: v=2.4 cv=IfOHWXqa c=1 sm=1 tr=0 ts=6a88694f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=ib87Wlh1110MIt0kNvEA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=knJC3oNaGZld7YiAmo3ERJaagVvs6+WKQCRvdcm/wPA=; b=ROnEcZ2CsgxmaLEy7T28a4G0fr SYBhcpY1lLuRyPwLGd5fhfZQSaL07YybCofpGb8Hv+T7aVOPKjphKhlOosiJMSPLaMIzrdG6B6JJw e/0TEa3SKwFajTL+OIzwjTjo4; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:44858 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxQoZ-00000003nKw-0Xsz; Fri, 21 Aug 2026 09:05:51 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: add default parameter for cp_demangled_name_to_comp errmsg In-Reply-To: <20260820180243.730651-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 20 Aug 2026 14:02:33 -0400") References: <20260820180243.730651-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 21 Aug 2026 09:05:50 -0600 Message-ID: <87bjavtsxd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxQoZ-00000003nKw-0Xsz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:44858 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfESREyD8uG53+UTONz5QtH8U3Ni2mn4dqcHZzvXPsAHbi/oFE/JmEikYJDI4ikauqpYyKvQKYeOkyysBHqX7AVSja7Ds/K+u5aj+jJspdtKLdbuzEtKJ hOlYuIvwPAaVk2aRlxwO+fPYkQVuoWTBeJHRh7v5ABDPqoy46IaQf3EhmXuBw1Z8T0mHmpSM7ztPHepYv3RvVWkBHSeRkz5OhRQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I am generally not a big fan of default values, especially when the Simon> parameter changes how the function behaves. But in this case it does Simon> really change the behavior of the function, so I think it's fine. I think maybe you left out a "not" from the second sentence here. Anyway this looks good to me. Approved-By: Tom Tromey Tom