From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vCndCQGbiGoleDQAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 14:37:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D0y/3o0U; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1284E1E033; Fri, 21 Aug 2026 14:37:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5B78E1E033 for ; Fri, 21 Aug 2026 14:37:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F6BF4BB1C3E for ; Fri, 21 Aug 2026 18:37:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F6BF4BB1C3E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D0y/3o0U Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 1935C4BB1C2D for ; Fri, 21 Aug 2026 18:37:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1935C4BB1C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1935C4BB1C2D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787337446; cv=none; b=dwQ1RUEjvqYMYaa6QY9GjvGkclhPDugR4M4C4MhcABAfLSPbMNeQphMmUWU5no9sASTzmvcDlAhjXn/ATcRgkXbzSlwR+6AU7WJgIZwtaaXr/c6YIc3zhY7Iv3SF5gmYdqGHyoDlnpw+GTnLoJrmhhacJI02sfSdxJ4slXtmMac= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787337446; c=relaxed/simple; bh=OQUfA3KKnQp3lOdQenWefX4gVtMmKHG4hA0m4+ANqpk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aIBg0TeHKjiBx3lmfMVIDVqXrhryzqeaXFer56vfu+XsAU6c1LWyR4W2nV/z3OwMvtMX/F8zH2tufLqfbMrxjBMeBYf3BMQqt4nb0ttKCSm2hxnY7BxU29r/ST+Ys1V8hbfFByQRuRESTBVSQrvMs7Jd5+YfxEhn91iXNnAumxo= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D0y/3o0U reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1935C4BB1C2D Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id xRuIwlmqmJFmFxU7JwaRIZ; Fri, 21 Aug 2026 18:37:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xU7Iw0lzTml7lxU7IwzVuB; Fri, 21 Aug 2026 18:37:24 +0000 X-Authority-Analysis: v=2.4 cv=KrBN2XWN c=1 sm=1 tr=0 ts=6a889ae4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=ZG7PQQAK3LeOI5ogSOcA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JWsvHRAVJs8Nigxk63pn0+zqMVyJqNsIxuyz1gngoew=; b=D0y/3o0UHix16+ogSYKtZ2pZEB LORbldvZqeXIhZSbs8mG1qJ9yUmg2ehupkJ1a9kLU34NKo4hZf8B5doZO0LjCtSL2TYzIWBNJb8ex rG7qa8rGuAZAHCQS8tge5JhOR; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:45648 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxU7I-00000002tiv-0oAw; Fri, 21 Aug 2026 12:37:24 -0600 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/8] Windows gdb: Get available XState features In-Reply-To: <20260727174619.1089041-6-ssbssa@yahoo.de> (Hannes Domani's message of "Mon, 27 Jul 2026 19:42:30 +0200") References: <20260727174619.1089041-1-ssbssa@yahoo.de> <20260727174619.1089041-6-ssbssa@yahoo.de> X-Attribution: Tom Date: Fri, 21 Aug 2026 12:37:23 -0600 Message-ID: <87bjavpbfg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxU7I-00000002tiv-0oAw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:45648 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIHR5EVVkYsD+Y/O/uxljL1qVplypZLITbMQPgJ4QDJXzV2w3lLXmLezegdHorKGpP7l5IuIWNjb0ZLRpU0dzVftpjyOdp8mJ30nWe7LWwbWxrN8NxuX rO4DmVzdB7aiqYywXESgzzUYIw3huUInfotbgUL8/GlFzkVwLHSSnTY+/kW+72gdjDOaFedPHCU05NdoySuCHO6+7ihKyVD8xfA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Hannes" == Hannes Domani writes: Hannes> Also prepares the thread context for the additional registers. SOme minor nits. Hannes> + CONTEXT *context = nullptr; Hannes> + if (!InitializeContext (th->context_buffer.get (), Hannes> + context_flags, &context, &xstate_size)) Hannes> + error ("InitializeContext failure %lu\n", GetLastError ()); How about throw_winerror_with_name instead? Hannes> +#if defined __i386__ || defined __x86_64__ Hannes> + if (GetEnabledXStateFeatures != nullptr Hannes> + && InitializeContext != nullptr Hannes> + && GetXStateFeaturesMask != nullptr Hannes> + && SetXStateFeaturesMask != nullptr Hannes> + && LocateXStateFeature != nullptr Hannes> +#ifdef __x86_64__ Hannes> + && RtlGetExtendedFeaturesMask != nullptr Hannes> + && RtlSetExtendedFeaturesMask != nullptr Hannes> + && RtlLocateExtendedFeature != nullptr Hannes> +#endif Hannes> + ) Hannes> + { Hannes> + /* Available XState features masked with implemented features. */ Hannes> + xstate_features = GetEnabledXStateFeatures () Hannes> + & (X86_XSTATE_AVX_AVX512_MASK | X86_XSTATE_CET_U); Formatting is off here, maybe parenthesize the RHS. Tom