From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zz+gCqhMqGq2wAwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 15:36:08 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eMJIEs+d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 195631E066; Mon, 14 Sep 2026 15:36:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 30D021E033 for ; Mon, 14 Sep 2026 15:36:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ABF384BB1C2A for ; Mon, 14 Sep 2026 19:36:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABF384BB1C2A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eMJIEs+d Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id BCA124BAE7DA for ; Mon, 14 Sep 2026 19:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BCA124BAE7DA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BCA124BAE7DA Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789414541; cv=none; b=o062O2Tq+9BSoUzuzbW5f1VyhENbIfmHXVk5QxqBNwrfbLpxqH1hHKT+xvHDsAAblyDBzE9JCHkBgiD/xdQ3W1LnJXY+tUEzPIZBleyejHlE7TSMpUWHSFUya9turBhvK2ENA6KIY4NCl/WExSbmgphZXcASdwST3jnwW/+Ph9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789414541; c=relaxed/simple; bh=4oYuOlyi3wkYJ8v0z5Zhqg3NlVIM0FD9lbVbI7TAasw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x6ZS3DMhnVioBExti0to617ZoNCFJjKRFHWubpX5sMMwrB5yfh4pzB+3Oecymdxnpc5OTJMgduj06jgMXsOJDKi2fvwYh+6BlLtmrNMpFbzcDiOvIMh1CRVbhxBI3gclSsWEGGW2NJHfHDaxM78q4qc7VbmXzXnq8I2tP5O7HkU= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eMJIEs+d reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCA124BAE7DA Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id 6BfyxKKxRuFzg6CSrxcgbO; Mon, 14 Sep 2026 19:35:41 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6CSpxvDuSadLA6CSqxYdU6; Mon, 14 Sep 2026 19:35:40 +0000 X-Authority-Analysis: v=2.4 cv=Aqzu3P9P c=1 sm=1 tr=0 ts=6aa84c8c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=D2G_dojfeNWxGHvX48sA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wGLktV/UBEBG7hXutKIGlr4bjgPPlZniPa9c6u5OUZQ=; b=eMJIEs+dqu/VY6oLW0OdkvEOG9 jd2Jwsiqb74pAm8uFqooNsUKIJZ9IgVggjkCyMf0Wq7hdf6UhZu7obC2PEWPbNlmkFp+ZjZ9cTC6d ckVwWg2R516W/+cjMJrO9u/7n; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:34780 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6CSp-00000000WVR-2YwW; Mon, 14 Sep 2026 13:35:39 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] gdb/python: collapse some nested ifs In-Reply-To: <20260914191908.557014-2-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 14 Sep 2026 15:19:02 -0400") References: <20260914191908.557014-1-simon.marchi@efficios.com> <20260914191908.557014-2-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 14 Sep 2026 13:35:38 -0600 Message-ID: <87bj9zwrqt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6CSp-00000000WVR-2YwW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:34780 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGkSkf1kSsqafxVfsBX6UEPU9O+kELix7FEl/Qx6TXoktZyErHb8b9zWKbS4GNBX1HHF3f836qK0vEkXGCnmn1xhK4QMHkcKUzf33eAQmdWGVEvczaFj AHaUi/vMVlohRzJmxZJ1aBPDD/5t4Khl5MTpGSoRteaPOh2BLSXePzm20z+JpmYjAXJ13IXWh7HnbdjLCnIl/GEt+W8VhszjYz8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> While reviewing another patch in gdb/python, I found that some nested Simon> "ifs" could be collapsed into one. I had Claude hunt for more cases Simon> like that throughout gdb/python, and this patch changes them. Simon> - if (ds_obj != NULL) Simon> + if (ds_obj != NULL && gdbpy_is_string (ds_obj.get ())) nullptr Approved-By: Tom Tromey Tom