From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122268 invoked by alias); 14 Jul 2018 01:15:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122253 invoked by uid 89); 14 Jul 2018 01:15:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=wondered, extensive, spu-tdep.c, sk:spu_get X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 01:15:52 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E23DA1E48F; Fri, 13 Jul 2018 21:15:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531530951; bh=UOCNG3oOpV3v4mQNpgvjXiJHkUFbwXhqbRfhVcLZzIc=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Yo6xqNTVnY7sYgfgPzzovjIH/lProhQoc6mTVRWLfzb3GCRl56V1j7NeTy8f+p1s1 iYxPgKRxoJqrH0oC6VPOSxNKDDhtj8nNJCfgaRnO+ColfXqUwzn9HjSZ+sWbhrZcUT z1+Jrb5gqE0SJA1+TRklYzWOdwp9sGLapNzDxewE= Subject: Re: [RFA 01/13] Simple unused variable removals To: Tom Tromey , gdb-patches@sourceware.org References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-2-tom@tromey.com> From: Simon Marchi Message-ID: <87b519fc-318a-84aa-7ced-aea354f059fb@simark.ca> Date: Sat, 14 Jul 2018 01:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180712205208.32646-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00437.txt.bz2 On 2018-07-12 04:51 PM, Tom Tromey wrote: > This patch holds all the straightforward unused variable deletions. I've looked at this patch and I didn't find anything that looked wrong to my eyes. In some cases, such as: --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1820,8 +1820,6 @@ spu_get_overlay_table (struct objfile *objfile) { CORE_ADDR vma = extract_unsigned_integer (ovly_table + 16*i + 0, 4, byte_order); - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4, - 4, byte_order); CORE_ADDR pos = extract_unsigned_integer (ovly_table + 16*i + 8, 4, byte_order); CORE_ADDR buf = extract_unsigned_integer (ovly_table + 16*i + 12, I wondered this was a bug (should that variable really be used), but I wouldn't know without some quite extensive research... so all-in-all, LGTM. Simon