Re: [testuite patch] Fix cross-arch .S testsuite files compatibility

Thomas Schwinge
2012-03-15T08:57:40Z

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Hi!

On Wed, 14 Mar 2012 21:20:20 +0100, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> on top of:
> [SH] gdb.dwarf2 tests: use .byte4 instead of .long
> http://sourceware.org/ml/gdb-patches/2012-03/msg00447.html
>
> some parts of this patch may not be required (such as
> gdb.arch/amd64-entry-value.s does not need fixes for non-amd64 asm compilers)
> but it has been made to make gdb_ari.sh quiet with its patch posting along).
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora17-linux-gnu.

> gdb/testsuite/
> 2012-03-14 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix build compatibility with non-x86* archs.
> * gdb.arch/amd64-entry-value.s: Replace # by /**/, .long by .4byte,
> .value by .2byte, drop #APP and #NO_APP.
> * [...]

In my patch I had explicitly taken care to replace .long with .4byte only
in .debug_* sections (and only in files that are not x86-specific, as it
doesn't matter for those). You're now proposing such changes, too:

--- a/gdb/testsuite/gdb.dwarf2/dw2-modula2-self-type.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-modula2-self-type.S
@@ -22,7 +22,7 @@
But "v" has been removed afterwards. */

.data
-v: .long 0
+v: .4byte 0

Or:

--- a/gdb/testsuite/gdb.dwarf2/typeddwarf-amd64.S
+++ b/gdb/testsuite/gdb.dwarf2/typeddwarf-amd64.S
@@ -175,24 +175,24 @@ _start:
.section .rodata.cst8,"aM",@progbits,8
.align 8
.LC0:
- .long 0
- .long 1074266112
+ .4byte 0
+ .4byte 1074266112

I just wanted to check whether we can be sure that .4byte always conveys
the same meaning as .long did in such cases? For example, on SH you
wouldn't get the alignment mismatch error (that prompted my original
patch) -- but that probably doesn't matter for the GDB testsuite, as we
would always have conforming assembler files (where no assembler errors
are expected; as opposed to the gas testsuite). Can there be other
semantic differences between the two?

(And no, I don't think you could reasonably encode ``don't allow .long --
but only in .debug_* sections'' in the ARI system...) :-)

Grüße,
Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]