Re: [testuite patch] Fix cross-arch .S testsuite files compatibility

Jan Kratochvil
2012-03-15T09:06:31Z

On Thu, 15 Mar 2012 09:57:11 +0100, Thomas Schwinge wrote:
> In my patch I had explicitly taken care to replace .long with .4byte only
> in .debug_* sections (and only in files that are not x86-specific, as it
> doesn't matter for those). You're now proposing such changes, too:

I checked specifically the "v" case where .debug_info already expects it takes
_4_ bytes:
.byte 0x4 /* DW_AT_byte_size */

It is true I did not check other cases but:

> I just wanted to check whether we can be sure that .4byte always conveys
> the same meaning as .long did in such cases?

as these testfiles were created on x86* .long is compiled there as .4byte.
This means that any such occurence of .long can be replaced by .4byte.

> Can there be other semantic differences between the two?

It is a good question and I am not aware of any such differences.

> (And no, I don't think you could reasonably encode ``don't allow .long --
> but only in .debug_* sections'' in the ARI system...) :-)

Fortunately we do not need full freedoms for the testfiles, we may restrict
them arbitrarily as long as one can write the needed testfiles afterwards.

Some of such restrictions would affecth gdb.arch/gdb.disasm testfiles so
I rather excluded them from the ARI verifications. gdb.arch/gdb.disasm
testfiles are not made as multi-arch, therefore these arch-compatibility
issues should not affect them.

Thanks,
Jan