From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92941-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29257 invoked by alias); 20 Jul 2012 16:27:59 -0000
Received: (qmail 29244 invoked by uid 22791); 20 Jul 2012 16:27:56 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Jul 2012 16:27:30 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6KGRUEX025590	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 20 Jul 2012 12:27:30 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6KGRTsZ023041	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 20 Jul 2012 12:27:30 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] target_wait/linux_nat_wait: Dump the passed in target options.
References: <20120720154934.25085.71708.stgit@brno.lan>
Date: Fri, 20 Jul 2012 16:27:00 -0000
In-Reply-To: <20120720154934.25085.71708.stgit@brno.lan> (Pedro Alves's	message of "Fri, 20 Jul 2012 16:49:34 +0100")
Message-ID: <87a9yuwg7i.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00397.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> +  if (list == NULL)
Pedro> +    return xstrdup (elem);
Pedro> +  else
Pedro> +    return concat (list, ", ", elem, (char *) NULL);

If list is non-NULL and allocated by malloc, then it will be leaked.

Pedro> +#define DO_TARG_OPTION(OPT) \
Pedro> +  ret = do_option (&target_options, ret, OPT, #OPT)
Pedro> +
Pedro> +  DO_TARG_OPTION (TARGET_WNOHANG);
Pedro> +
Pedro> +  if (target_options != 0)
Pedro> +    ret = str_comma_list_concat_elem (ret, "unknown???");

That could conceivably happen here.

I think the fix is just to use

 return reconcat (list, list, ", ", elem, (char *) NULL);

Tom