From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18226 invoked by alias); 23 Aug 2012 20:23:34 -0000 Received: (qmail 18215 invoked by uid 22791); 23 Aug 2012 20:23:32 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_XL X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 20:23:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7NKNG4d020136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 Aug 2012 16:23:16 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7NKNFec003047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 23 Aug 2012 16:23:16 -0400 From: Tom Tromey To: swamy sangamesh Cc: gdb-patches@sourceware.org Subject: Re: AIX 64bit support References: Date: Thu, 23 Aug 2012 20:23:00 -0000 In-Reply-To: (swamy sangamesh's message of "Thu, 9 Aug 2012 13:53:14 +0530") Message-ID: <87a9xlnyrw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00699.txt.bz2 >>>>> ">" == swamy sangamesh writes: >> Below patches adds the support for 64-bit gdb for ppc64 running on >> AIX, plus some bug fixes which are caused >> by the way gcc and xlc generated binary are read. Please consider the >> patches if its fine. Thanks for writing this. First, you will need to file copyright assignment paperwork with the FSF before we can accept this patch. Contact me off-list and I can get you started on the process. >> --- ./gdb/aix-thread.c_orig 2012-08-07 17:11:21.270057686 +0530 >> +++ ./gdb/aix-thread.c 2012-08-07 17:11:17.998084929 +0530 [...] >> static int >> +#ifdef BFD64 >> +ptrace64aix (int req, long long id, long long addr, int data, int *buf) I tend to doubt that BFD64 is the correct check here. I think you can use --enable-64-bit-bfd even on a 32-bit machine. However in that situation you would not want to use ptrace64 -- presumably it wouldn't even exist. Perhaps checking directly for ptrace64 in configure is best. I agree with the other commenters about the desirability of a wrapper function, rather than repeated #ifdefs all over. >> --- ./gdb/inf-ptrace.c_orig 2012-07-25 21:07:04.273078850 +0530 >> +++ ./gdb/inf-ptrace.c 2012-08-02 00:35:56.425443341 +0530 There are many changes here, but I think this code is shared by many ports. So, your changes have to take that into consideration. A wrapper function may be the way to go. >> --- ./gdb/xcoffread.c_orig 2012-08-07 17:36:42.378057756 +0530 >> +++ ./gdb/xcoffread.c 2012-08-07 17:36:48.702060320 +0530 I don't know anything about xcoffread. Could you say how you tested this? Did you test it on a 32-bit host as well? >> --- ./gdb/symtab.c_orig 2012-08-07 17:52:15.181060405 +0530 >> +++ ./gdb/symtab.c 2012-08-07 17:53:04.653058722 +0530 There is a change here, but this is generic code, and I think shouldn't have an xlc-specific change. The problem has to be approached some other way, preferably in the debuginfo reader. The BFD changes should go to the binutils list. Tom