From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12968 invoked by alias); 17 Oct 2012 17:16:13 -0000 Received: (qmail 12957 invoked by uid 22791); 17 Oct 2012 17:16:11 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 17:15:51 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HHFoGf004053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Oct 2012 13:15:50 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9HHFnPS020264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 17 Oct 2012 13:15:50 -0400 From: Tom Tromey To: "Andrew Burgess" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Display full file path in MI style disassembly listing References: <506DB4B8.5030001@broadcom.com> Date: Wed, 17 Oct 2012 17:16:00 -0000 In-Reply-To: <506DB4B8.5030001@broadcom.com> (Andrew Burgess's message of "Thu, 4 Oct 2012 17:09:28 +0100") Message-ID: <87a9vl3tq2.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00286.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> + char *filename; I think this could be const. Andrew> + Andrew> + filename = s->fullname; Andrew> + if (filename == NULL) Andrew> + { Andrew> + filename = symtab_to_fullname (s); Andrew> + if (filename == NULL) Andrew> + filename = s->filename; Andrew> + } Andrew> + Andrew> ui_out_field_int (uiout, "line", line); Andrew> ui_out_text (uiout, "\tin "); Andrew> - ui_out_field_string (uiout, "file", s->filename); Andrew> + ui_out_field_string (uiout, "file", filename); Andrew> ui_out_text (uiout, "\n"); It isn't obvious to me that this only applies to the MI case. Can you explain that? Tom