Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] class-local typedef substitutions
Date: Fri, 02 Nov 2012 20:52:00 -0000	[thread overview]
Message-ID: <87a9uzohhi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87hap9qbqm.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu,	01 Nov 2012 15:01:05 -0600")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Pedro> I'm confused and curious at why such a change would be necessary.  I
Pedro> couldn't find it from a quick look over the patch.
Pedro> Can you expand a little?  Does this also affect the CLI?

Tom> It has been a while, but I think the difference depends on whether the
Tom> type name is sent through canonicalization or not.

Yes, it is due to C++ name canonicalization.

It may be possible to avoid this in some cases, but I can't think of a
situation where the current approach would make the output worse.

It does affect the CLI in some cases, but I see now that I missed the
'default' case in c_type_print_base.  I will update that and see what
happens.

Pedro> Why expect both long and "long int"?  Is this compiler / debug format
Pedro> dependent, perhaps?

Tom> I will take another look and figure it out.

I think it is safe to just expect "long".
I'll change the patch.

Tom


  reply	other threads:[~2012-11-02 20:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 18:51 Tom Tromey
2012-09-08  8:00 ` Eli Zaretskii
2012-09-21 19:32 ` Tom Tromey
2012-10-31 19:18   ` Pedro Alves
2012-11-01 21:01     ` Tom Tromey
2012-11-02 20:52       ` Tom Tromey [this message]
2012-11-05 20:26         ` Tom Tromey
2012-11-05 20:52           ` Eli Zaretskii
2012-11-06 15:14             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9uzohhi.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox