From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22895 invoked by alias); 18 Jan 2013 15:28:24 -0000 Received: (qmail 22887 invoked by uid 22791); 18 Jan 2013 15:28:23 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 15:28:19 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0IFSFNZ025284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Jan 2013 10:28:15 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0IFSDD9007922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 18 Jan 2013 10:28:14 -0500 From: Tom Tromey To: Hui Zhu Cc: Yao Qi , Joel Brobecker , gdb-patches ml Subject: Re: [PATCH] Add CTF support to GDB [5] Add test for CTF function References: <50F3ADB8.1000603@codesourcery.com> <50F55E11.40008@codesourcery.com> <50F67844.5040007@codesourcery.com> Date: Fri, 18 Jan 2013 15:28:00 -0000 In-Reply-To: (Hui Zhu's message of "Fri, 18 Jan 2013 09:22:49 +0800") Message-ID: <87a9s6a4tu.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00432.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> +set ctfdir $testfile.ctf I'd like it if new temporary files were all named using standard_output_file. This way we can move them later. Hui> +#Test "tsave -ctf" Space after "#". Hui> +#Get the pathname of babeltrace and set it to $which_babeltrace. Hui> +#If host doesn't have babeltrace, $which_babeltrace will set to 0. Hui> +if [info exists BABELTRACE] { Hui> + set which_babeltrace ${BABELTRACE} Hui> +} else { Hui> + if [is_remote host] then { Hui> + remote_exec host "which babeltrace" "" "" "babeltrace.which" This seems possibly questionable to me, but I don't really do any remote host testing. Is this used elsewhere in the test suite? Hui> +#Clean Hui> + Hui> +#remote_exec host "rm -rf $ctfdir" You might as well just delete this. I tend to think that having tests clean up after themselves is inconvenient, as it makes debugging any failures trickier -- you have to hack the test case and run it again in order to see the various files. I'm not sure whether this has ever been discussed here though. I do see that a fair number of tests do this kind of cleanup. Tom