From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97924-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 344 invoked by alias); 23 Jan 2013 15:35:46 -0000
Received: (qmail 32410 invoked by uid 22791); 23 Jan 2013 15:35:44 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jan 2013 15:35:41 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0NFZdeJ013319	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 23 Jan 2013 10:35:40 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0NFZcSI008601	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 23 Jan 2013 10:35:39 -0500
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC - GDB Python API] New gdb.Architecture class
References: <CAGyQ6gwAU-Qj-jkhj7gA7rG=xQOcZbp=g4Km8A3b6bLfsCWMqg@mail.gmail.com>	<87sj5u31ku.fsf@fleche.redhat.com>	<CAGyQ6gyWn4+W3ty56K6RASoKpRgmFQEt9crmYsUVYoVSkUK6tQ@mail.gmail.com>	<87wqv4x6ib.fsf@fleche.redhat.com>	<CAGyQ6gwTY59xn-g13Fk_E6s8+RuNO=D2WEh3N70jRMtP5NmE7w@mail.gmail.com>
Date: Wed, 23 Jan 2013 15:35:00 -0000
In-Reply-To: <CAGyQ6gwTY59xn-g13Fk_E6s8+RuNO=D2WEh3N70jRMtP5NmE7w@mail.gmail.com>	(Siva Chandra's message of "Wed, 23 Jan 2013 05:53:04 -0800")
Message-ID: <87a9rzx67p.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00554.txt.bz2

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva> 2013-01-22  Siva Chandra Reddy  <sivachandra@google.com>
Siva>         Add a new class gdb.Architecture which exposes GDB's
Siva>         internal representation of architecture via GDB Python API.

Siva>         * Makefile.in: Add entries corresponding to the new file
Siva>         python/py-arch.c.
Siva>         * python/py-arch.c: Implement gdb.Architecture class.
Siva>         * python/py-frame.c (frapy_arch): Implement the method
Siva>         gdb.Frame.architecture().
Siva>         (frame_object_methods): Add 'architecture' to the method table.
Siva>         * python/python-internal.h: Add declarations of new utility
Siva>         functions.
Siva>         * python/python.c (_initialize_python): Initialize
Siva>         gdb.Architecture class.

Siva> doc/

Siva>         * gdb.texinfo (Architectures In Python): New sub-sub-section
Siva>         describing the gdb.Architecture class.
Siva>         (Frames In Python): Add description about the new method
Siva>         Frame.architecture().

Siva> testsuite/

Siva>         * gdb.python/frame.exp: Add a test for Frame.architecture()
Siva>         method.

The code bits are ok.
It still needs a doc review though.

Tom