From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [3/3] unconditionally call via SYMBOL_COMPUTED_OPS
Date: Thu, 07 Feb 2013 16:52:00 -0000 [thread overview]
Message-ID: <87a9rgvzg7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130207163233.GA15297@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 7 Feb 2013 17:32:33 +0100")
Jan> We could talk differently if SYMBOL_COMPUTED_OPS would apply for
Jan> all LOC_*, the full virtualization. But that would require
Jan> resolving first the inappropriate reuse of SYMBOL_COMPUTED_OPS for
Jan> DW_AT_frame_base in function symbols.
Jan> Without the full virtualization / unconditional calls via
Jan> SYMBOL_COMPUTED_OPS I do not understand this patch and I am against
Jan> it.
I thought I had made this "has a frame-base" change, but I don't see it.
WTF? You are right to oppose this now.
I'll write the needed patch.
If you're against the full virtualization plan, it would be nice to know now.
IIUC this was the original point of all those FIXME comments. But if
nobody wants it, we can just drop them directly.
Tom
next prev parent reply other threads:[~2013-02-07 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 16:09 Tom Tromey
2013-02-07 16:32 ` Jan Kratochvil
2013-02-07 16:52 ` Tom Tromey [this message]
2013-02-07 17:03 ` Jan Kratochvil
2013-02-08 11:52 ` Tom Tromey
2013-02-08 18:27 ` Jan Kratochvil
2013-02-14 18:24 ` Tom Tromey
2013-03-20 18:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9rgvzg7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox