From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22824 invoked by alias); 10 May 2013 16:09:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22814 invoked by uid 89); 10 May 2013 16:09:55 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 16:09:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4AG9nfq005231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 May 2013 12:09:49 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4AG9jEb022166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 May 2013 12:09:47 -0400 From: Tom Tromey To: Freddie Chopin Cc: gdb-patches@sourceware.org Subject: Re: Fix for bug 15414 - Build fails with mingw32-w64 GCC-4.8.0 References: <518BDB4F.2070509@op.pl> Date: Fri, 10 May 2013 16:09:00 -0000 In-Reply-To: <518BDB4F.2070509@op.pl> (Freddie Chopin's message of "Thu, 09 May 2013 19:22:23 +0200") Message-ID: <87a9o2hl4m.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00391.txt.bz2 >>>>> "Freddie" == Freddie Chopin writes: Freddie> http://sourceware.org/bugzilla/show_bug.cgi?id=15414 Freddie> The idea of change comes from Tom Tromey This turned out to be a pain to apply and prepare for checkin, since it meant re-running autoconf in a bunch of places and also touching many ChangeLog files. Something is wrong when preparing a patch is much, much harder than writing it in the first place... Anyway here is what I am checking in. I think this is under the copyright assignment limit since I wrote the gdb change, and since nearly all of the rest of the patch is autoconf output. Tom sim/bfin/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/common/ChangeLog: 2013-05-10 Freddie Chopin PR build/15414: * acinclude.m4 (SIM_AC_OPTION_WARNINGS): Do not use -Wformat-nonliteral with -Wno-format. sim/cr16/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/cris/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/d10v/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/igen/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/m68hc11/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/mips/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/mn10300/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. sim/v850/ChangeLog: 2013-05-10 Freddie Chopin * configure: Rebuild. gdb/ChangeLog: 2013-05-10 Freddie Chopin Tom Tromey PR build/15414: * configure: Rebuild. * configure.ac (build_warnings): Do not use -Wformat-nonliteral with -Wno-format. Index: sim/bfin/configure =================================================================== RCS file: /cvs/src/src/sim/bfin/configure,v retrieving revision 1.17 diff -u -r1.17 configure --- sim/bfin/configure 26 Mar 2013 18:00:03 -0000 1.17 +++ sim/bfin/configure 10 May 2013 16:06:02 -0000 @@ -13339,7 +13339,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13347,6 +13347,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/common/acinclude.m4 =================================================================== RCS file: /cvs/src/src/sim/common/acinclude.m4,v retrieving revision 1.10 diff -u -r1.10 acinclude.m4 --- sim/common/acinclude.m4 26 Mar 2013 18:00:03 -0000 1.10 +++ sim/common/acinclude.m4 10 May 2013 16:06:03 -0000 @@ -872,7 +872,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -880,6 +880,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac AC_ARG_ENABLE(build-warnings, Index: sim/cr16/configure =================================================================== RCS file: /cvs/src/src/sim/cr16/configure,v retrieving revision 1.12 diff -u -r1.12 configure --- sim/cr16/configure 20 Nov 2012 14:41:08 -0000 1.12 +++ sim/cr16/configure 10 May 2013 16:06:05 -0000 @@ -12887,7 +12887,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -12895,6 +12895,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/cris/configure =================================================================== RCS file: /cvs/src/src/sim/cris/configure,v retrieving revision 1.20 diff -u -r1.20 configure --- sim/cris/configure 26 Mar 2013 18:00:03 -0000 1.20 +++ sim/cris/configure 10 May 2013 16:06:06 -0000 @@ -13238,7 +13238,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13246,6 +13246,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/d10v/configure =================================================================== RCS file: /cvs/src/src/sim/d10v/configure,v retrieving revision 1.24 diff -u -r1.24 configure --- sim/d10v/configure 20 Nov 2012 14:41:09 -0000 1.24 +++ sim/d10v/configure 10 May 2013 16:06:07 -0000 @@ -12887,7 +12887,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -12895,6 +12895,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/igen/configure =================================================================== RCS file: /cvs/src/src/sim/igen/configure,v retrieving revision 1.11 diff -u -r1.11 configure --- sim/igen/configure 20 Nov 2012 14:41:12 -0000 1.11 +++ sim/igen/configure 10 May 2013 16:06:11 -0000 @@ -4800,7 +4800,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -4808,6 +4808,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/m68hc11/configure =================================================================== RCS file: /cvs/src/src/sim/m68hc11/configure,v retrieving revision 1.26 diff -u -r1.26 configure --- sim/m68hc11/configure 26 Mar 2013 18:00:04 -0000 1.26 +++ sim/m68hc11/configure 10 May 2013 16:06:17 -0000 @@ -13237,7 +13237,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13245,6 +13245,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/mips/configure =================================================================== RCS file: /cvs/src/src/sim/mips/configure,v retrieving revision 1.49 diff -u -r1.49 configure --- sim/mips/configure 26 Mar 2013 18:00:04 -0000 1.49 +++ sim/mips/configure 10 May 2013 16:06:20 -0000 @@ -13266,7 +13266,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13274,6 +13274,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/mn10300/configure =================================================================== RCS file: /cvs/src/src/sim/mn10300/configure,v retrieving revision 1.28 diff -u -r1.28 configure --- sim/mn10300/configure 26 Mar 2013 18:00:04 -0000 1.28 +++ sim/mn10300/configure 10 May 2013 16:06:22 -0000 @@ -13243,7 +13243,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13251,6 +13251,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: sim/v850/configure =================================================================== RCS file: /cvs/src/src/sim/v850/configure,v retrieving revision 1.24 diff -u -r1.24 configure --- sim/v850/configure 20 Nov 2012 14:41:26 -0000 1.24 +++ sim/v850/configure 10 May 2013 16:06:30 -0000 @@ -13237,7 +13237,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wno-pointer-sign \ +-Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes" @@ -13245,6 +13245,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac # Check whether --enable-build-warnings was given. Index: gdb/configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.202 diff -u -r1.202 configure.ac --- gdb/configure.ac 10 May 2013 12:10:20 -0000 1.202 +++ gdb/configure.ac 10 May 2013 16:06:32 -0000 @@ -1919,7 +1919,7 @@ # NOTE: If you change this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ --Wformat-nonliteral -Wpointer-sign \ +-Wpointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ -Wno-switch -Wno-char-subscripts -Wmissing-prototypes \ -Wdeclaration-after-statement -Wempty-body" @@ -1928,6 +1928,7 @@ # GCC versions complain about %I64. case "${host}" in *-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;; + *) build_warnings="$build_warnings -Wformat-nonliteral" ;; esac AC_ARG_ENABLE(build-warnings,