From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101725-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32567 invoked by alias); 20 May 2013 15:16:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32549 invoked by uid 89); 20 May 2013 15:16:48 -0000
X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
X-Spam-User: qpsmtpd, 2 recipients
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 15:16:47 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4KFGd5Z015982	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 20 May 2013 11:16:39 -0400
Received: from barimba (ovpn-113-72.phx2.redhat.com [10.3.113.72])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4KFGbg9022579	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 20 May 2013 11:16:37 -0400
From: Tom Tromey <tromey@redhat.com>
To: Christian Groessler <chris@groessler.org>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb@sourceware.org,        gdb-patches@sourceware.org
Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion
References: <51936596.8010205@groessler.org> <m3hai3kes8.fsf@redhat.com>	<5195E023.10203@groessler.org> <87a9ntr1xl.fsf@fleche.redhat.com>	<5196B5CA.1000704@groessler.org>
Date: Mon, 20 May 2013 15:16:00 -0000
In-Reply-To: <5196B5CA.1000704@groessler.org> (Christian Groessler's message	of "Sat, 18 May 2013 00:57:14 +0200")
Message-ID: <87a9npof57.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00731.txt.bz2

>>>>> ">" == Christian Groessler <chris@groessler.org> writes:

Just FYI - your patch got word-wrapped.

>> +                 lappend dirs [join [list $r$x$comp$l$f]]

My suggestion for "join" was really odd.  I was confused...
It is simpler to just use string concatenation like

    lappend dirs $r$x$comp$l$f

The patch is ok with that change.

thanks,
Tom