From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10503 invoked by alias); 28 Jun 2013 15:58:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10470 invoked by uid 89); 28 Jun 2013 15:58:07 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 15:58:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5SFw0Ub002254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jun 2013 11:58:00 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5SFvwbv005473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 28 Jun 2013 11:57:59 -0400 From: Tom Tromey To: Mircea Gherzan Cc: palves@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] gdbserver, common: convert some variadic macros to C99 References: <1372322622-3216-1-git-send-email-mircea.gherzan@intel.com> <1372322622-3216-3-git-send-email-mircea.gherzan@intel.com> Date: Fri, 28 Jun 2013 16:02:00 -0000 In-Reply-To: <1372322622-3216-3-git-send-email-mircea.gherzan@intel.com> (Mircea Gherzan's message of "Thu, 27 Jun 2013 10:43:37 +0200") Message-ID: <87a9makz21.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00886.txt.bz2 >>>>> "Mircea" == Mircea Gherzan writes: Mircea> #ifdef GDBSERVER Mircea> -#define DEBUG_AGENT(fmt, args...) \ Mircea> +#define DEBUG_AGENT(...) \ This is a funny situation. Officially, GDB is C89, while varargs macros are c99. However, the existing code here is a GNU extension. Clearly nobody has ever tried to compile this code with a compiler other than GCC. I would like us to adopt C99, but I think this requires some community agreement. Tom