From: Sergio Durigan Junior <sergiodj@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Pedro Alves'" <palves@redhat.com>,
"'GDB Patches'" <gdb-patches@sourceware.org>
Subject: Re: Build failure following: Implement support for checking /proc/PID/coredump_filter commit
Date: Wed, 08 Apr 2015 16:47:00 -0000 [thread overview]
Message-ID: <87a8yi1sar.fsf@redhat.com> (raw)
In-Reply-To: <001c01d07218$fd5daa20$f818fe60$@muller@ics-cnrs.unistra.fr> (Pierre Muller's message of "Wed, 8 Apr 2015 18:28:02 +0200")
On Wednesday, April 08 2015, Pierre Muller wrote:
>> Please try the users/palves/gnulib-strtok_r branch.
>
> I can confirm that I am able to build mingw32 64bit gdb.exe executable,
> and it contains gnulib/import/strtok_r.c source.
That is great, thanks Pierre.
> I am not really able to test that the code works OK,
> as I don't really know how to trigger that code...
The code will not work on native Windows debugging, so there is nothing
to test there. If you debug a remote GNU/Linux target, you should be
able to tweak the value of /proc/PID/coredump_filter on the target and
generate different kinds of corefiles based on it. But I don't know how
hard it would be for you to test this.
> I have no idea what we should do now...
IMO the easiest and safest thing to do now would be to just import the
strtok_r module from gnulib (without updating it).
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2015-04-08 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 23:57 [PATCH v4 0/2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902) Sergio Durigan Junior
2015-03-24 23:57 ` [PATCH 2/2] Documentation and testcase Sergio Durigan Junior
2015-03-27 9:53 ` Pedro Alves
2015-03-24 23:57 ` [PATCH 1/2] Implement support for checking /proc/PID/coredump_filter Sergio Durigan Junior
2015-03-27 9:53 ` Pedro Alves
2015-03-31 23:40 ` Sergio Durigan Junior
2015-04-08 14:08 ` Build failure following: Implement support for checking /proc/PID/coredump_filter commit Pierre Muller
2015-04-08 14:43 ` Pedro Alves
2015-04-08 15:14 ` Pedro Alves
2015-04-08 16:08 ` Sergio Durigan Junior
2015-04-08 16:28 ` Pierre Muller
2015-04-08 16:47 ` Sergio Durigan Junior [this message]
2015-04-08 17:21 ` Pedro Alves
2015-04-08 16:27 ` Yao Qi
2015-04-08 16:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8yi1sar.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox