Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Friday, July 24 2015, Simon Marchi wrote:

> On 15-07-24 03:53 PM, Eli Zaretskii wrote:
>> I don't think there are so many shells out there that we run a real
>> risk of forgetting them.
>
> Even though you can try to list all known shells, they won't necessarily
> be in the same location.  For example, the servers I work on at work have
> an old version of everything, so I use my own version of bash.  SHELL won't
> be /bin/bash but /home/<user>/local/bin/bash.  gdb wouldn't recognize it as
> a valid shell.
>
>> And even if we do, there's plenty of time
>> till the next release to hear from those who might be negatively
>> impacted.
>
> I don't think that's true.  The number of users who go build and use gdb
> from the master branch is probably negligible.  If this affects some users,
> it will most likely be when it gets released in distros (months or years
> after the actual release, depending on the distro).

Yeah, I don't agree with this proposal as well.  I will submit a v2
soon, without Eli's proposal, and see what others say.  If others also
prefer Eli's idea, we can discuss the details.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/