From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50139 invoked by alias); 14 Jul 2017 16:15:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50056 invoked by uid 89); 14 Jul 2017 16:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy5.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 16:15:43 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 854AE140935 for ; Fri, 14 Jul 2017 10:12:39 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id kgCc1v00c2f2jeq01gCfo7; Fri, 14 Jul 2017 10:12:39 -0600 X-Authority-Analysis: v=2.2 cv=eYdNR/MH c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=20KFwNOVAAAA:8 a=Sra9mRCkjTn6J0swuB0A:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:49290 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dW3Cm-003e1r-Ay; Fri, 14 Jul 2017 10:12:36 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Remove BITS_IN_BYTES define References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-3-tom@tromey.com> <5a4a5c82-c956-34a6-ede9-f30ca9879848@redhat.com> Date: Fri, 14 Jul 2017 16:15:00 -0000 In-Reply-To: <5a4a5c82-c956-34a6-ede9-f30ca9879848@redhat.com> (Pedro Alves's message of "Fri, 14 Jul 2017 16:16:22 +0100") Message-ID: <87a847uhe5.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dW3Cm-003e1r-Ay X-Source-Sender: 174-29-39-24.hlrn.qwest.net (pokyo) [174.29.39.24]:49290 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-07/txt/msg00190.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 07/13/2017 01:34 PM, Tom Tromey wrote: >> @@ -432,8 +432,8 @@ print_scalar_formatted (const gdb_byte *valaddr, struct type *type, >> case 'd': >> case 'u': >> { >> - bool is_signed = options->format != 'u' || !TYPE_UNSIGNED (type); >> - print_decimal_chars (stream, valaddr, len, is_signed, byte_order); >> + bool is_unsigned = options->format == 'u' || TYPE_UNSIGNED (type); >> + print_decimal_chars (stream, valaddr, len, !is_unsigned, byte_order); >> } >> break; >> case 0: Pedro> Ah, looks like you meant to squash this hunk in the previous patch... Oops, sorry about this. I'll fix it up. Tom