From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8060 invoked by alias); 29 Nov 2017 19:39:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8027 invoked by uid 89); 29 Nov 2017 19:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 19:39:51 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE1F75F7BB for ; Wed, 29 Nov 2017 19:39:49 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5ACB5D6A3; Wed, 29 Nov 2017 19:39:46 +0000 (UTC) From: Sergio Durigan Junior To: Sergio Lopez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command References: <20171128132148.31802-1-slp@redhat.com> <20171128132148.31802-2-slp@redhat.com> <87induo1ey.fsf@redhat.com> Date: Wed, 29 Nov 2017 19:39:00 -0000 In-Reply-To: (Sergio Lopez's message of "Wed, 29 Nov 2017 11:59:34 +0100") Message-ID: <87a7z4ho1q.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00792.txt.bz2 On Wednesday, November 29 2017, Sergio Lopez wrote: > On Tue, Nov 28, 2017 at 4:42 PM, Sergio Durigan Junior > wrote: >> On Tuesday, November 28 2017, Sergio Lopez wrote: >>> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c >>> index 24237b8d39..5f4a1cdad1 100644 >>> --- a/gdb/linux-tdep.c >>> +++ b/gdb/linux-tdep.c >>> @@ -93,6 +93,11 @@ struct smaps_vmflags >>> >>> static int use_coredump_filter = 1; >>> >>> +/* Whether to honor the VM_DONTDUMP flag in /proc/PID/smaps when >>> + generating a corefile. */ >>> + >>> +static int honor_dontdump_flag = 1; >> >> No empty line between command and definition of variable. > > This is the only suggestion that I haven't applied because it would > break the coding style of the previous lines: > > gdb/linux-tdep.c: > 89 }; > 90 > 91 /* Whether to take the /proc/PID/coredump_filter into account when > 92 generating a corefile. */ > 93 > 94 static int use_coredump_filter = 1; > 95 > 96 /* Whether the value of smaps_vmflags->exclude_coredump should be > 97 ignored, including mappings marked with the VM_DONTDUMP flag in > 98 the dump. */ > 99 > 100 static int dump_excluded_mappings = 0; > 101 > 102 /* This enum represents the signals' numbers on a generic architecture The previous line is the one breaking our coding style. Unfortunately GDB is full of these inconsistencies, but please remove the empty line in your patch anyway. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/