Re: [RFA 4/8] Constify prompt argument to read_command_lines

Pedro Alves
2018-04-24T16:43:30Z

On 04/19/2018 08:15 PM, Tom Tromey wrote:
> The prompt argument to read_command_lines can be const. This patch
> makes this change, and also removes some fixed-sized buffers in favor
> of using string_printf.
>
> 2018-04-19 Tom Tromey <tom@tromey.com>
>
> * tracepoint.c (actions_command): Update.
> * cli/cli-script.h (read_command_lines): Update.
> * cli/cli-script.c (read_command_lines): Constify prompt_arg.
> (MAX_TMPBUF): Remove define.
> (define_command): Use string_printf.
> (document_command): Likewise.
> * breakpoint.c (commands_command_1): Update.

Looks good.

Thanks,
Pedro Alves