From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101780 invoked by alias); 30 Apr 2018 14:40:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101769 invoked by uid 89); 30 Apr 2018 14:40:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 14:40:04 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 8D46B3ECE8A for ; Mon, 30 Apr 2018 09:40:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id D9yEfqVfKQUwqD9yEfaViL; Mon, 30 Apr 2018 09:40:02 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:50598 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fD9yE-003hnX-B0; Mon, 30 Apr 2018 09:40:02 -0500 From: Tom Tromey To: Phil Muldoon Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 7/8] Allow breakpoint commands to be set from Python References: <20180425154133.3989-1-tom@tromey.com> <20180425154133.3989-8-tom@tromey.com> <2e135d0d-4bb7-49f7-7397-71e656fd4d57@redhat.com> Date: Mon, 30 Apr 2018 14:40:00 -0000 In-Reply-To: <2e135d0d-4bb7-49f7-7397-71e656fd4d57@redhat.com> (Phil Muldoon's message of "Mon, 30 Apr 2018 14:07:42 +0100") Message-ID: <87a7tk7o72.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fD9yE-003hnX-B0 X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:50598 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00646.txt.bz2 Phil> The code bits LGTM but on a somewhat side note I'm wondering if there Phil> are any side effects with the Python breakpoint stop callback? This Phil> shouldn't interfere with the viability of this patch, though, because Phil> a breakpoint previously could have had a command list attached to it Phil> after being created in Python and via the commands command. I'm mildly Phil> curious what would get called first. The stop method is called first and the commands are only run if stop returns True. There's no conflict between the two. Tom