From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126694 invoked by alias); 8 Jul 2018 16:33:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126676 invoked by uid 89); 8 Jul 2018 16:33:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=U*simark, sk:simark@, simark@simark.ca, Hx-languages-length:1118 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:33:11 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 967DC400C9F3A for ; Sun, 8 Jul 2018 11:33:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCcXfvie3aSeycCcXfZLL4; Sun, 08 Jul 2018 11:33:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HXLhmiyn+0ox/O3XqQhFKr9/9aR9nHxZyZD0E2ic0Vg=; b=FUoVSzIxIuGOzJMo2d/lw6Ea0y hBPRnMO9PCP0F5pT2gP7ivFvccEQXvsIZzwLpbfAdkwIf3uD0F2RbqtC+/BTFrXlorf+Od1LxKz+L 1fU8CtRFc3P9HyIa83LAPAHq+; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42988 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCcX-001Sh3-Bp; Sun, 08 Jul 2018 11:33:09 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com> Date: Sun, 08 Jul 2018 16:33:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 6 Jul 2018 23:51:06 -0400") Message-ID: <87a7r1662j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00187.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >> @@ -140,6 +147,12 @@ struct buildsym_compunit >> /* The subfile of the main source file. */ >> struct subfile *main_subfile = nullptr; >> >> + /* Name of source file whose symbol data we are now processing. This >> + comes from a symbol of type N_SO for stabs. For Dwarf it comes Simon> I think it's spelled DWARF (all caps)? Yeah, I just moved the old comment; but I've updated it now. >> + from the DW_AT_name attribute of a DW_TAG_compile_unit DIE. */ >> + >> + gdb::unique_xmalloc_ptr m_last_source_file; Simon> Nit: remove the empty line between the comment and the field. Done. Simon> Should this new field be private? All the data members are private by the end of the series, but I didn't generally try to do that at each step along the way. This is one of those compromises I mentioned in the cover letter -- where a bigger reordering of the series might have yielded a prettier series, but didn't seem worth the effort. Tom