From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123599 invoked by alias); 19 Jul 2018 14:40:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123468 invoked by uid 89); 19 Jul 2018 14:40:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=f.i X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jul 2018 14:40:56 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 4A0E07636A for ; Thu, 19 Jul 2018 09:40:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gA6PfxiPwPvAdgA6if2d16; Thu, 19 Jul 2018 09:40:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S4oPtashGhFW+iFWEvzPFUZWIF6V5aGa8Wp9w8I4Vqc=; b=heNr0I9wv9WusQzMzyQvh9JQbo JLTcknV2rufC77yjACu9T7sXzqHPmVCXxfPRety59GYVUCaCzPSUY5dA8fISMvEmZHAifO7k6rV1S 8Z8tF+V8q3Ffa9SSrdCwJwOcx; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44132 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fgA6P-001Sqg-2o; Thu, 19 Jul 2018 09:40:21 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [RFC][PATCH][symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count References: <20180718171814.br2yfrfajkyk6i2j@delia> Date: Thu, 19 Jul 2018 14:40:00 -0000 In-Reply-To: <20180718171814.br2yfrfajkyk6i2j@delia> (Tom de Vries's message of "Wed, 18 Jul 2018 19:18:14 +0200") Message-ID: <87a7qni90r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00578.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> this patch (without test-case for now) generates a warning if Tom> DW_AT_upper_bound or DW_AT_count is defined, but can't be translated. This Tom> is triggered for current gcc in lto mode for vla test-cases. Tom> F.i.: Tom> ... Tom> $ gcc gcc/testsuite/gcc.dg/guality/vla-1.c -g -O2 -flto \ Tom> -DPREVENT_OPTIMIZATION -o ./vla-1.exe Tom> $ ./gdb -batch -ex "set complaints 10" -ex "file ./vla-1.exe" Tom> During symbol reading, Unresolved DW_AT_upper_bound - DIE at 0x337 Tom> [in module vla-1.exe]. Tom> ... Tom> Good idea? I think so. Tom> + if (attr_ub) [...] Tom> + if (attr_count) The gdb style is to use a check against nullptr in these spots. Tom