From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83987 invoked by alias); 3 Oct 2018 21:07:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83726 invoked by uid 89); 3 Oct 2018 21:07:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.192.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 21:07:50 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 9D707400C5CD0 for ; Wed, 3 Oct 2018 15:14:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7oMXgDT3OkBj67oMpgKV7b; Wed, 03 Oct 2018 16:07:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ls4yhYrPrd2CdEVpbGh/0bY0Xkm0nleF66JlugpajCI=; b=rWyRKfxSjHtE++ot5wS7KM3Kab 0DBHdlNhs8DypG2LCb3UirFRVMnx7AfmULcWM36f64Dsoq8NQeGs563zH2BB2wsSSSk3/JF+WxCFg mLVofjPwn5tmyZ+n1wjKE/bie; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49574 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g7oMX-0006em-Ch; Wed, 03 Oct 2018 16:07:17 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/10] Use unsigned as base type for some enums References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-4-tom@tromey.com> <8037ff67-25db-de97-f64c-8f9b24f38778@redhat.com> Date: Wed, 03 Oct 2018 21:07:00 -0000 In-Reply-To: <8037ff67-25db-de97-f64c-8f9b24f38778@redhat.com> (Pedro Alves's message of "Wed, 3 Oct 2018 18:33:04 +0100") Message-ID: <87a7nukad7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00094.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This LGTM, except a nit. During the discussion around v1, the conclusion Pedro> was that we can't add the assertion to the class, but adding it to Pedro> operator~ would work. That information is lost on whoever ends up reading Pedro> this code later on. Could you add a comment? Or if you prefer, update the Pedro> commit log to mention it? I've added a comment. Tom