From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43167 invoked by alias); 21 Oct 2018 16:47:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43064 invoked by uid 89); 21 Oct 2018 16:47:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=protocol, userfriendly, user-friendly, Sunday X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 21 Oct 2018 16:47:10 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A4FD83F3E; Sun, 21 Oct 2018 16:47:09 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD82F7E676; Sun, 21 Oct 2018 16:47:08 +0000 (UTC) From: Sergio Durigan Junior To: John Darrington Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] GDB: Fix documentation for invoking GDBSERVER References: <20181013175801.2670-1-john@darrington.wattle.id.au> <20181013175801.2670-3-john@darrington.wattle.id.au> <871s8nxaoj.fsf@redhat.com> <20181019070549.6zu5fcdftmefqtzs@jocasta.intra> <87zhv9vf6t.fsf@redhat.com> <20181021073327.nl4k6ryh2bwqerzs@jocasta.intra> Date: Sun, 21 Oct 2018 16:47:00 -0000 In-Reply-To: <20181021073327.nl4k6ryh2bwqerzs@jocasta.intra> (John Darrington's message of "Sun, 21 Oct 2018 09:33:27 +0200") Message-ID: <87a7n7uu0j.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00465.txt.bz2 On Sunday, October 21 2018, John Darrington wrote: > On Fri, Oct 19, 2018 at 04:45:14PM -0400, Sergio Durigan Junior wrote: > > The check needs to implemented on gdbserver/remote-utils.c:remote_open, > and gdbserver needs to error out if "hint.ai_protocol == IPPROTO_UDP". > And "parse_connection_spec_without_prefix" could be merged with > "parse_connection_spec". > > A quick test shows that this is not necessary. Any attempt to start > gdbserver with udp: will never get to remote_open because remote_prepare > will fail when it gets to listen: > > "Can't listen on socket: Operation no supported." > > (listen is for connection orientated protocols only). Yes, but this error message is not entirely clear. We should show a more user-friendly message, and the best way to do that is to do an early check for the UDP protocol. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/