From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49492 invoked by alias); 4 Dec 2018 16:50:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49477 invoked by uid 89); 4 Dec 2018 16:50:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=encrypted X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 16:50:12 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C2CD308219A for ; Tue, 4 Dec 2018 16:50:11 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DA3310840E4; Tue, 4 Dec 2018 16:50:11 +0000 (UTC) From: Sergio Durigan Junior To: Keith Seitz Cc: GDB Patches Subject: Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search References: <20181130172148.18830-1-sergiodj@redhat.com> <87ftvi1mi3.fsf@tromey.com> <87zhtqqw3p.fsf@redhat.com> Date: Tue, 04 Dec 2018 16:50:00 -0000 In-Reply-To: (Keith Seitz's message of "Tue, 4 Dec 2018 08:44:29 -0800") Message-ID: <87a7llnsn1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00040.txt.bz2 On Tuesday, December 04 2018, Keith Seitz wrote: > On 11/30/18 10:05 AM, Sergio Durigan Junior wrote: >> On Friday, November 30 2018, Tom Tromey wrote: >> >>>>>>>> "Sergio" == Sergio Durigan Junior writes: >>> >>> Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1613614 >>> Sergio> * dwarf2read.c (dwarf2_find_containing_comp_unit): Add >>> Sergio> 'mid_cu->length' to '*cu_off' when checking if 'sect_off' is >>> Sergio> inside the CU. >>> >>> Thanks for the extensive analysis. >>> I agree this is correct; please check this in. >> >> Thanks for the quick review. This has been pushed: >> >> 81fbbaf96216ed88973a069e4ed25379d7421ec8 >> > > Is this needed for 8.2 branch? Yep, I'd say so. This seems like a simple patch to be backported to 8.2, but I'll wait for a global maintainer to give the green light so that I can create a proper bug. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/