From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89958 invoked by alias); 29 Dec 2018 19:15:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89901 invoked by uid 89); 29 Dec 2018 19:15:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.189) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 29 Dec 2018 19:15:34 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 3769D66FD27 for ; Sat, 29 Dec 2018 13:15:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dK57gYebx2PzOdK57gG78V; Sat, 29 Dec 2018 13:15:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XTu85CWa/cONechmMLL4WB3vVkq7E1dceJfkpU+bOts=; b=b/eWDLhb3NvyyCAEiJpIBPeAhj bMnuD7qnZy9PxvmXmvB/BKE8iZaffOiCSds9PIzRb280IP4HyFtNPfBn9Vc6wRtNsNLLBRnCasZJJ Dva7wGU/24VWTsr3wtskdG8gC; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:36574 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gdK56-001o6b-U5; Sat, 29 Dec 2018 13:15:33 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix leak in most gdb.mi tests. References: <20181229170116.8588-1-philippe.waroquiers@skynet.be> Date: Sat, 29 Dec 2018 19:15:00 -0000 In-Reply-To: <20181229170116.8588-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 29 Dec 2018 18:01:16 +0100") Message-ID: <87a7kom9ez.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00415.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Fix the leak by freeing in mi_execute_command_input_handler Philippe> the command allocated in gdb_readline_no_editing_callback. Philippe> Tested on amd64, native and under valgrind. Philippe> gdb/ChangeLog Philippe> 2018-12-29 Philippe Waroquiers Philippe> * mi/mi-interp.c (mi_execute_command_input_handler): xfree cmd, Philippe> allocated in gdb_readline_no_editing_callback. Thanks. Would you mind adding to the comment comment above struct ui::input_handler (in top.h) to explain that input_handler takes ownership of the string? This all seems somewhat ugly to me. Perhaps ideally the caller should manage the memory and input_handler should take a const char *? But not your problem, fixing the leak is enough. This is ok with the comment tweak. Tom