From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121284 invoked by alias); 9 Jan 2019 23:10:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121275 invoked by uid 89); 9 Jan 2019 23:10:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 23:10:10 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D2BBC3FD4A for ; Wed, 9 Jan 2019 17:10:08 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id hMzAgqg6QYTGMhMzAgbsM9; Wed, 09 Jan 2019 17:10:08 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kfvEspYHbPDuAMh9OC1sZBMDo4S0dj5/pYpxX1oX3yE=; b=DmcBVv9sMc2gjsPZskiGjt0vnq HLI967cMjSLPGppBA/C3EtG5+YyUi0fffK+fGuHx4OTkEGke5sh4ezBG46EEjHfFHxkEdQAgh8Rcu WyvGHOhvKKoBFdMvbtvMRyLyo; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:59378 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ghMzA-000OAy-I3; Wed, 09 Jan 2019 17:10:08 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , Simon Marchi , "gdb-patches\@sourceware.org" Subject: Re: [RFA] Fix leak in linespec.c References: <20190108062452.3942-1-philippe.waroquiers@skynet.be> <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> <8736q2zmqz.fsf@tromey.com> <1547004364.1500.5.camel@skynet.be> Date: Wed, 09 Jan 2019 23:10:00 -0000 In-Reply-To: <1547004364.1500.5.camel@skynet.be> (Philippe Waroquiers's message of "Wed, 09 Jan 2019 04:26:04 +0100") Message-ID: <87a7k9xwa8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00207.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> 54 gdb/testsuite/v7_outputs/gdb.base/reread/gdb.log == Conditional jump or move depends on uninitialised value(s) I think I have a fix for this one. I plan to check it in soon, maybe today, as it's been around for quite a while. Philippe> 1 gdb/testsuite/v7_outputs/gdb.cp/inherit/gdb.log == Invalid read of size 8 Philippe> 1 gdb/testsuite/v7_outputs/gdb.cp/virtbase/gdb.log == Invalid read of size 2 Philippe> 5 gdb/testsuite/v7_outputs/gdb.cp/virtbase/gdb.log == Invalid read of size 8 I believe I saw these with ASAN as well. I think what happens here is that the pretty-printer code creates a value from a virtual base class slice of an object, but doesn't "inflate" it to the full object, resulting in some out-of-bounds reads. Tom