Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

Yao Qi
2015-09-15T08:56:14Z

Don Breazeal <donb@codesourcery.com> writes:

Hi Don,
I happen to read the code you pushed in some days ago...

> @@ -2111,6 +2112,12 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
> if (target_supports_vfork_events ())
> report_vfork_events = 1;
> }
> + if (strcmp (p, "exec-events+") == 0)

Shouldn't we use "else if"?

> + {
> + /* GDB supports and wants exec events if possible. */
> + if (target_supports_exec_events ())
> + report_exec_events = 1;
> + }
> else
> target_process_qsupported (p);

--
Yao (齐尧)

From bb592f4d75544fda59a290cadf46bd33067220fc Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Tue, 15 Sep 2015 09:52:11 +0100
Subject: [PATCH] Fix typo

gdb/gdbserver:

2015-09-15 Yao Qi <yao.qi@linaro.org>

* server.c (handle_query): Check string comparison using
"else if" instead of "if".

diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index 1481c47..c82c232 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -2112,7 +2112,7 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
if (target_supports_vfork_events ())
report_vfork_events = 1;
}
- if (strcmp (p, "exec-events+") == 0)
+ else if (strcmp (p, "exec-events+") == 0)
{
/* GDB supports and wants exec events if possible. */
if (target_supports_exec_events ())