From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22557 invoked by alias); 10 May 2019 18:48:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22490 invoked by uid 89); 10 May 2019 18:48:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 May 2019 18:48:01 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 97653DBF0B for ; Fri, 10 May 2019 13:48:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PAYqhqScRdnCePAYqhYlx6; Fri, 10 May 2019 13:48:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=alyqLi+tskn4BgaDgtTcj3c7kbJoNvdUJV6NF/96CpA=; b=DgYxPCnm4fa7JYxnNoRVMs2uSU McZ1xAg4V16qaL/VYdBtln0f9CgIG5oARJjwtfXC/cDzj2Nr1OYLcQHZWHRkI2oc+l9UwUIo/9YHO wqwt/nzD+I/Q60GrJMUB/Ltq+; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:33808 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hPAYq-003pf6-Cr; Fri, 10 May 2019 13:48:00 -0500 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Tom de Vries Subject: Re: [PATCH] Fix GDB build when using --disable-gdbmi References: <20190510183512.9955-1-simon.marchi@efficios.com> Date: Fri, 10 May 2019 18:48:00 -0000 In-Reply-To: <20190510183512.9955-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 10 May 2019 14:35:12 -0400") Message-ID: <87a7fu9me8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00260.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> To fix it, I added a config.h macro, HAVE_GDBMI, defined if we build Simon> with GDB/MI support. We can then use it in breakpoint.c to Simon> conditionally use mi_multi_location_breakpoint_output_fixed. If Simon> building without GDB/MI, the value of use_fixed_output is not really Simon> important, as it is only used to fix an issue when printing breakpoints Simon> in MI. I'm not sure if it's better or not, but ui_out has a "flags" feature that could be applied to this. This would mean not having to have a #if. Tom