From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28092 invoked by alias); 20 Oct 2019 22:30:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28062 invoked by uid 89); 20 Oct 2019 22:30:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1936, letter X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Oct 2019 22:30:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571610599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tL876OsWCpARG1Re6svEFYSK7SPiEKZMGdtLNZzy+dc=; b=IYzm3oZrBleqhkE6FenNIpFVaHN3I66dWZKcIgRgaVO3I5zTVntH1H/00JxVgRhTfSgN1S mK3PMob+9aPKUkSDr2jdKwf4/CNyx4WvtZAK9x6GLvpQ2GoNiCPWxx7jowVLXPfnNYhxbi 98rRVPLwcoW+ZojfKqjSNUhL7I82CVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-yAibJ8QxMGChgWf0Hb6nqg-1; Sun, 20 Oct 2019 18:29:56 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A42EB1800DCA; Sun, 20 Oct 2019 22:29:55 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7790E60606; Sun, 20 Oct 2019 22:29:55 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: some thoughts on gerrit References: <877e4z8ovc.fsf@tromey.com> <87eez7f423.fsf@redhat.com> Date: Sun, 20 Oct 2019 22:30:00 -0000 In-Reply-To: <87eez7f423.fsf@redhat.com> (Sergio Durigan Junior's message of "Sun, 20 Oct 2019 18:24:52 -0400") Message-ID: <87a79vf3to.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00704.txt.bz2 On Sunday, October 20 2019, I wrote: > On Sunday, October 20 2019, Tom Tromey wrote: >> The cover letter is often a good guide to what is going on in the >> series. See for example: >> >> https://sourceware.org/ml/gdb-patches/2019-10/msg00590.html >> >> It seems a shame to lose this. > > I absolutely agree. > >> One counter-argument about the cover letter I thought of is that, >> because it doesn't end up in the history, maybe the lack of it will >> force us to make each commit message even clearer. And, we should do >> that ... it's just that the roadmap is handy when reviewing. > > I see your point, but I still think a cover letter serves a different > purpose than the commit messages. A cover letter introduces the big > picture, and it is often a good place for reviewers to make generic > comments about the overall implementation. > >> I wonder if there'd be a way to make "git review" prompt for a cover >> letter and attach it somewhere as a comment. > > That could work, I guess, but it would still be a bit cumbersome. > > I found this on gerrit's bugzilla: > > https://bugs.chromium.org/p/gerrit/issues/detail?id=3D924 > > It seems like there was a request, but it was closed very recently due > to inactivity. Perhaps we could try pushing a bit more... Ah, something I forgot to say: a possible (but hacky) workaround that I thought for the cover letter problem is to create an empty commit before everything else, with just the commit message. We'd have to "garbage-collect" it manually when the series is pushed (or maybe we can figure out a way to do that automatically; not sure), but it could work... The other problem with this workaround is that it will not be possible to create threading using the cover letter as the root message. Thanks, --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/