From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40877 invoked by alias); 9 Jan 2020 18:54:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40861 invoked by uid 89); 9 Jan 2020 18:54:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.48.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 18:54:47 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 1B6EA400C4F1E for ; Thu, 9 Jan 2020 11:42:54 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id pcxCihU2YHunhpcxCiqyrV; Thu, 09 Jan 2020 12:54:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jvu5Cn0Le3ivKI9lNchbUsFtu7agdR5AB5ekMbqJc3s=; b=iVdedCvhrR6CuhVItW3zblfh2F DnvZnGCaH/hnVWULnTzi09w4fLF2MD+v168aekXO2BlqG0SyKAOI6BGs4XVo7LfRWsYK6MtoxFbAg 5uEIGx1PLMtvf6bJnBANfHrDg; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:34292 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ipcxC-003QhQ-7l; Thu, 09 Jan 2020 11:54:46 -0700 From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix/Update misc comments References: <20200106143620.2881-1-luis.machado@linaro.org> <87d0bsr6cz.fsf@tromey.com> <94f2157f-4a2a-5d7b-7aa8-b557e01e8f6d@linaro.org> Date: Thu, 09 Jan 2020 18:54:00 -0000 In-Reply-To: <94f2157f-4a2a-5d7b-7aa8-b557e01e8f6d@linaro.org> (Luis Machado's message of "Thu, 9 Jan 2020 12:38:35 -0300") Message-ID: <87a76w7956.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00216.txt.bz2 Luis> That's the confusing part. There is a single_step (...) function for Luis> gdbserver linux-low, but i don't see such a function for gdb. Luis> So this reference looks stale to me. Hah, I jumped to the tag and saw the function existed, but forgot to check the directory. The patch seems fine to me. You can check it in. If Pedro has some suggestions, we can always put in another patch. Tom